Add checkbox fields for review requests.

Review Request #9156 - Created Aug. 29, 2017 and updated

David Trowbridge
Review Board
release-3.0.x
90cdb26...
reviewboard

This change adds Python and JavaScript classes to add checkbox-type fields in
review requests. Extensions can use this very simply by just subclassing
BaseCheckboxField and providing field_id and label attributes. The
resulting boolean value will be stored in extra_data as expected.

  • Ran js-tests.
  • Ran unit tests.
  • Created a test extension that used a checkbox field and verified that the
    state was correctly rendered when loading the page and correctly stored when
    the checkbox was clicked.
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Christian Hammond
David Trowbridge
Review request changed

Description:

~  

This change adds python and javascript classes to add checkbox-type fields in

  ~

This change adds Python and JavaScript classes to add checkbox-type fields in

    review requests. Extensions can use this very simply by just subclassing
    BaseCheckboxField and providing field_id and label attributes. The
    resulting boolean value will be stored in extra_data as expected.

Commit:

-bd7819cb7dbbca4b4c8e054f0374a0aa62aa66fc
+90cdb264730805be722bb9eb4aef7d37a449d465

Diff:

Revision 2 (+206)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...