Summary

Add custom formatting to rbt status

Review Request #9153 — Created Aug. 28, 2017 and submitted Aug. 30, 2017, 12:46 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

0d88269...

Reviewers

Groups

rbtools

People

Description

The rbt status command now supports two new flags:

--format for specifying a custom output format instead of a
tabulated format. This is useful for custom script integration with
the command.
-z which makes the custom-formatted lines nul-terminated.

Testing Done

Used this with a fish completion for rbt land -r and rbt post -r.
Posted and update to this change using said completion.

Issues

Description	From	Last Updated
W391 blank line at end of file	reviewbot	Aug. 28, 2017, 3:30 p.m.
Period at the end. That said, I don't know that we need docs for this inner function. Maybe we could …	david	Aug. 30, 2017, 11:10 a.m.
Instead of setting this as a variable and then printing, how about just print(format % info, end=end)?	david	Aug. 30, 2017, 11:10 a.m.
F841 local variable 'end' is assigned to but never used	reviewbot	Aug. 30, 2017, 11:11 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/status.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Testing Done:

~		Used this with a fish completion for `rbt land -r` and `rbt post -r`.
	~	Used this with a fish completion for `rbt land -r` and `rbt post -r`.
	+	Posted and update to this change using said completion.

Commit:

-	8a67be5d5dc946dc5e3bd5c8f0aa91038b5909f5
+	d61b401d2ba152fc9f186cd5483efe672dbf1b3e

Diff:

Revision 2 (+79 -20)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/status.py (Diff revision 2)

The issue has been resolved. Show all issues

Period at the end. That said, I don't know that we need docs for this inner function.

Maybe we could even use a lambda and stick it inline?

rbtools/commands/status.py (Diff revision 2)

The issue has been resolved. Show all issues

Instead of setting this as a variable and then printing, how about just print(format % info, end=end)?

Change Summary:

Addressed David's issues

Commit:

-	d61b401d2ba152fc9f186cd5483efe672dbf1b3e
+	22e6aec30c4fb912dc0d3d02b3ff8c3a0708870d

Diff:

Revision 3 (+68 -20)

Show changes

rbtools/commands/status.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/status.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F841 local variable 'end' is assigned to but never used
```

Commit:

-	22e6aec30c4fb912dc0d3d02b3ff8c3a0708870d
+	0d8826903c49435f46df9760a18076a4f61adfac

Diff:

Revision 4 (+68 -20)

Show changes

rbtools/commands/status.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (1a13ed8)