Summary

Add a base models/views for pages.

Review Request #9151 — Created Aug. 25, 2017 and submitted Sept. 4, 2017, 4:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

f7b36d4...

Reviewers

Groups

reviewboard

People

Description

This introduces RB.Page and RB.PageView, which are base classes used
for any pages managed by RB.PageManager. These currently don't have
any real functionality, but will allow us to move some logic further
down in the future.

Testing Done

Unit tests passed.

Tested all types of pages (datagrid, review request, diff viewer,
review UIs) to make sure everything worked.

Issues

Description	From	Last Updated
Can we introduce an initialize method that just assigns this.options = options?	david	Aug. 30, 2017, 4:42 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/pages/views/pageView.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

Can we introduce an initialize method that just assigns this.options = options?

chipx86 Aug. 30, 2017, 4:31 p.m.

Let me actually introduce a different view (RB.View or something) for this in a different change, so it will apply to more than just pages.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (5c6c5e9)