• 
      

    Add a base models/views for pages.

    Review Request #9151 — Created Aug. 25, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    f7b36d4...

    Reviewers

    This introduces RB.Page and RB.PageView, which are base classes used
    for any pages managed by RB.PageManager. These currently don't have
    any real functionality, but will allow us to move some logic further
    down in the future.

    Unit tests passed.

    Tested all types of pages (datagrid, review request, diff viewer,
    review UIs) to make sure everything worked.

    Description From Last Updated

    Can we introduce an initialize method that just assigns this.options = options?

    daviddavid
    david
    1. 
        
    2. Show all issues

      Can we introduce an initialize method that just assigns this.options = options?

      1. Let me actually introduce a different view (RB.View or something) for this in a different change, so it will apply to more than just pages.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (5c6c5e9)