Perforce binary file diff corruption fix

Review Request #915 — Created July 15, 2009 and submitted

Information

Review Board SVN (deprecated)

Reviewers

When a binary file differed, post-review would miss printing a newline after "Binary Files differ", making the diff invalid for the subsequent file.  This would cause that file's diff to be lost silently when parsed by reviewboard on the server side.  Here's the patch.

 
chipx86
  1. 
      
  2. /trunk/rbtools/scripts/post-review (Diff revision 1)
     
     
    dl is a list. This shouldn't really work.
    1. This is a shorthand to appending newlines because a string is an iterable.  Granted, it isn't the most clear, so I am posting a new diff that uses append.
      
  3. 
      
TR
Review request changed
david
  1. Submitted as SVN r2065. Thanks!
  2. 
      
Loading...