Convert ReviewRequestEditorView to ES6.

Review Request #9129 - Created Aug. 9, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
dcb87b4...
reviewboard

This change is a straightforward conversion of one of our larger files to ES6.

Ran js-tests.

  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

David Trowbridge
Barret Rennie
  1. 
      
  2. Any reason to not do render(...args) and then use args here?

    1. Well, we'd still need to use either .apply() or .call() to pass in the context, so it seems like extra transpilation overhead for no benefit.

  3. 
      
Barret Rennie
  1. 
      
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (810df56)
Loading...