Summary

Convert ReviewRequestEditorView to ES6.

Review Request #9129 — Created Aug. 9, 2017 and submitted Aug. 25, 2017, 11:18 p.m.

Owner

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

dcb87b4...

Groups

People

Description

This change is a straightforward conversion of one of our larger files to ES6.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
Col: 15 'editorView' is defined but never used.	reviewbot	Aug. 9, 2017, 9 p.m.
Any reason to not do render(...args) and then use args here?	brennie	Aug. 25, 2017, 11:06 p.m.

flake8 passed.

JSHint failed.

Commit:

e46f8f53cc51e2d4d7db2a0e394927045bacc2b7

dcb87b449670bb7b28249ead1c2a32ce71f26b1b

Diff:

Revision 2 (+687 -621)

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 2)

The issue has been dropped. Show all issues

Any reason to not do render(...args) and then use args here?

Well, we'd still need to use either .apply() or .call() to pass in the context, so it seems like extra transpilation overhead for no benefit.

Ship it!