Inherit from API mixins in all resources
Review Request #9125 — Created Aug. 11, 2017 and submitted
Previously the extension and validation resources did not inherit from
the API token mixin nor the OAuth2 token mixin, making them inaccessible
via these methods. This was because they were not using our base
resource class due to being special cases of resources from Djblets.Now we have a new
RBResourceMixinthat includes all mixins that Review
Board resources should inherit from. Resources defined by Review Board
will inherit them through our baseWebAPIResource, but this mixin will
also allow us to use all these mixins in resources we bring in from,
e.g., Djblets.The new extension resource explicitly inherits from this mixin, as does
the validation resource, allowing them to be accessed via OAuth2 tokens
and API token.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Typo in the description: "becuase" |
 chipx86
|
|
|
E305 expected 2 blank lines after class or function definition, found 1 |
 reviewbot
|
|
|
E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
"subclasses" |
chipx86
|
|
|
You shouldn't need this. If the method doesn't provide docs, the augmented method's docs are used. |
chipx86
|
- Change Summary:
-
fix imports
- Commit:
-
45bc2807f43afab5ba55a35f08faf8729c350719e8b134c0d3eae986ee2a2df7c30e1aa2d598a9b0
Checks run (2 succeeded)
- Change Summary:
-
Addressed Christian's issues
- Description:
-
Previously the extension and validation resources did not inherit from
the API token mixin nor the OAuth2 token mixin, making them inaccessible ~ via these methods. This was becuase they were not using our base ~ via these methods. This was because they were not using our base resource class due to being special cases of resources from Djblets. Now we have a new
RBResourceMixinthat includes all mixins that ReviewBoard resources should inherit from. Resources defined by Review Board will inherit them through our base WebAPIResource, but this mixin willalso allow us to use all these mixins in resources we bring in from, e.g., Djblets. The new extension resource explicitly inherits from this mixin, as does
the validation resource, allowing them to be accessed via OAuth2 tokens and API token.
