Inherit from API mixins in all resources

Review Request #9125 — Created Aug. 11, 2017 and submitted

Information

Review Board
release-3.0.x
e8b134c...

Reviewers

Previously the extension and validation resources did not inherit from
the API token mixin nor the OAuth2 token mixin, making them inaccessible
via these methods. This was because they were not using our base
resource class due to being special cases of resources from Djblets.

Now we have a new RBResourceMixin that includes all mixins that Review
Board resources should inherit from. Resources defined by Review Board
will inherit them through our base WebAPIResource, but this mixin will
also allow us to use all these mixins in resources we bring in from,
e.g., Djblets.

The new extension resource explicitly inherits from this mixin, as does
the validation resource, allowing them to be accessed via OAuth2 tokens
and API token.

Ran unit tests.

Description From Last Updated

Typo in the description: "becuase"

chipx86chipx86

E305 expected 2 blank lines after class or function definition, found 1

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

"subclasses"

chipx86chipx86

You shouldn't need this. If the method doesn't provide docs, the augmented method's docs are used.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

brennie
brennie
chipx86
  1. 
      
  2. Show all issues

    Typo in the description: "becuase"

  3. reviewboard/webapi/base.py (Diff revision 3)
     
     
    Show all issues

    "subclasses"

  4. Show all issues

    You shouldn't need this. If the method doesn't provide docs, the augmented method's docs are used.

  5. 
      
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (047c0e9)
Loading...