flake8
-
reviewboard/webapi/resources/extension.py (Diff revision 1) -
reviewboard/webapi/resources/validation.py (Diff revision 1) E128 continuation line under-indented for visual indent
Review Request #9125 — Created Aug. 11, 2017 and submitted
Previously the extension and validation resources did not inherit from
the API token mixin nor the OAuth2 token mixin, making them inaccessible
via these methods. This was because they were not using our base
resource class due to being special cases of resources from Djblets.Now we have a new
RBResourceMixin
that includes all mixins that Review
Board resources should inherit from. Resources defined by Review Board
will inherit them through our baseWebAPIResource
, but this mixin will
also allow us to use all these mixins in resources we bring in from,
e.g., Djblets.The new extension resource explicitly inherits from this mixin, as does
the validation resource, allowing them to be accessed via OAuth2 tokens
and API token.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Typo in the description: "becuase" |
chipx86 | |
E305 expected 2 blank lines after class or function definition, found 1 |
reviewbot | |
E128 continuation line under-indented for visual indent |
reviewbot | |
"subclasses" |
chipx86 | |
You shouldn't need this. If the method doesn't provide docs, the augmented method's docs are used. |
chipx86 |
reviewboard/webapi/resources/extension.py (Diff revision 1) |
---|
reviewboard/webapi/resources/validation.py (Diff revision 1) |
---|
E128 continuation line under-indented for visual indent
fix imports
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+43 -11) |
reviewboard/webapi/resources/extension.py (Diff revision 3) |
---|
You shouldn't need this. If the method doesn't provide docs, the augmented method's docs are used.
Addressed Christian's issues
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+41 -11) |