• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Move comment anchor URL handling into the ReviewRequestPage.PageView.
    
 
    

    



 
    
 
    

  Review Request #9122
  —
  Created Aug. 6, 2017 and submitted 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-3.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  1204d7f...
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Until now, the Issue Summary Table has been handling URLs with a
    
#comment123 hash and taking care of expanding the appropriate review
    
and jumping to the right place on the page. This meant that these URLs
    
wouldn't work if the Issue Summary Table wasn't being used on the page,
    
and was a bit redundant with the page view's own URL handling.
    

    This change moves the handling of anchors fully into the review request
    
page's view, consolidating logic into one place and making the Issue
    
Summary Table fully self-contained.
    
 
    

    





  

    
 
 
    
  
    Unit tests pass.
    

    Tested URLs pointing to an issue in a collapsed entry, and saw that it
    
handled navigating to the right place.
    
 
    

    




 
    

    





    
 
    









 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    Can we explicitly set to null here?
    
          		
      
       daviddavid
      
      
       
      
     
    



     
    
      
       
       
    Would be slightly more readable as hash.contains('comment')
    
          		
      
       daviddavid
      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/reviewRequestPage/views/pageView.es6.js
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Can we explicitly set to null here?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/static/rb/js/reviewRequestPage/views/pageView.es6.js
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    




      
 
      
  
  
  

  
  
   Show all issues
  
 
      

      



    
      Would be slightly more readable as hash.contains('comment')
      
  
      
 
      

 
      
  


      
 
      
 
        

  


      1. 
 
 
        
 
        
  
 
        
 
        
  
        That's not a method on strings.
        
 
        

        2. 



      2. 
 
 
        
 
        
  
 
        
 
        
  
        Sorry, meant includes: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/includes
        
 
        

        3. 



      3. 
 
 
        
 
        
  
 
        
 
        
  
        No support in IE, and it's not much better than indexOf for that. Going to stick with the current code.
        
 
        

        4. 



      4. 
 
 
        
 
        
  
 
        
 
        
  
        It's included in the babel polyfill, which makes it fall back to indexOf. It makes the code more readable even if it's "not much better"
        
 
        

        5. 



      5. 
 
 
        
 
        
  
 
        
 
        
  
        Ah okay, so long as it's polyfilled.
        
 
        

        6. 


 
      


      

 
      

      4. 




    4. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



chipx86




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



chipx86




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-3.0.x (1057380)