Move comment anchor URL handling into the ReviewRequestPage.PageView.

Review Request #9122 - Created Aug. 6, 2017 and updated

Christian Hammond
Review Board
release-3.0.x
1204d7f...
reviewboard

Until now, the Issue Summary Table has been handling URLs with a
#comment123 hash and taking care of expanding the appropriate review
and jumping to the right place on the page. This meant that these URLs
wouldn't work if the Issue Summary Table wasn't being used on the page,
and was a bit redundant with the page view's own URL handling.

This change moves the handling of anchors fully into the review request
page's view, consolidating logic into one place and making the Issue
Summary Table fully self-contained.

Unit tests pass.

Tested URLs pointing to an issue in a collapsed entry, and saw that it
handled navigating to the right place.

  • 0
  • 1
  • 1
  • 2
Description From Last Updated
David Trowbridge
Christian Hammond
Review request changed

Change Summary:

Set a variable to null by default.

Commit:

-0c345a2696117ec17bb0d56b45324b02e37cb085
+1204d7f380e4daca30b4cef549e4f9624892d25b

Diff:

Revision 2 (+19 -28)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
David Trowbridge
  1. Ship It!
  2. 
      
Loading...