Fix Search API on 2.5

Review Request #9115 - Created Aug. 1, 2017 and submitted

Barret Rennie
Review Board
release-2.5.x
9116
reviewboard

Review Board 2.5's webapi_check_local_site passes the local_site
parameter in addition to the local_site_name. This was causing the
_search_* methods to receive two copies of local_site, resulting in
an error. This issue has been resolved by just passing the Local Site
directly in via **kwargs.

Ran unit tests. They all pass with this patch applied and did not
previously.

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
Barret Rennie
Christian Hammond
  1. 
      
  2. Can you add unit tests for this?

    1. This patch fixes failing unit tests.

  3. 
      
Christian Hammond
  1. 
      
  2. Can you also make the summary a bit more self-explanatory? It should make a reference to local sites being broken.

  3. 
      
Barret Rennie
Barret Rennie
Barret Rennie
Christian Hammond
  1. 
      
  2. I want to see real-world testing in the Testing Done. Can you confirm the fix on global sites, Local Sites, and on RBCommons?

    1. Discussed over Slack. Updating the testing in the commit to reflect the testing.

  3. 
      
Christian Hammond
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (21da4b4)
Loading...