Summary

Fix Search API on 2.5

Review Request #9115 — Created Aug. 1, 2017 and submitted Aug. 7, 2017, 2:44 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Blocks

9116

Reviewers

Groups

reviewboard

People

Description

Review Board 2.5's webapi_check_local_site passes the local_site
parameter in addition to the local_site_name. This was causing the
_search_* methods to receive two copies of local_site, resulting in
an error. This issue has been resolved by just passing the Local Site
directly in via **kwargs.

Testing Done

Ran unit tests. They all pass with this patch applied and did not
previously.

Issues

Description	From	Last Updated
Can you add unit tests for this?	chipx86	Aug. 1, 2017, 4:25 p.m.
Can you also make the summary a bit more self-explanatory? It should make a reference to local sites being broken.	chipx86	Aug. 5, 2017, 3:04 p.m.
I want to see real-world testing in the Testing Done. Can you confirm the fix on global sites, Local Sites, …	chipx86	Aug. 7, 2017, 1:01 p.m.

flake8 passed.

JSHint passed.

Testing Done:: +
Ran unit tests.

The issue has been dropped. Show all issues
```
Can you add unit tests for this?
```
1. brennie Aug. 1, 2017, 4:25 p.m.
  This patch fixes failing unit tests.

The issue has been resolved. Show all issues

Can you also make the summary a bit more self-explanatory? It should make a reference to local sites being broken.

Summary:: Fix Search API on 2.5
Fix Search API for LocalSites on 2.5

Testing Done:: ~
Ran unit tests.
~
Ran unit tests. They all pass with this patch applied and did not
+ previously.

Change Summary:: As it turns out, its broken when not on a LocalSite as well.
Summary:: Fix Search API for LocalSites on 2.5
Fix Search API on 2.5

The issue has been resolved. Show all issues

I want to see real-world testing in the Testing Done. Can you confirm the fix on global sites, Local Sites, and on RBCommons?

chipx86 Aug. 7, 2017, 2:42 p.m.

Discussed over Slack. Updating the testing in the commit to reflect the testing.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (21da4b4)

~		Ran unit tests.
	~	Ran unit tests. They all pass with this patch applied and did not
	+	previously.