Summary

Move more JavaScript for the review request page to the new bundle.

Review Request #9093 — Created July 20, 2017 and submitted July 22, 2017, 4:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

9558177...

Reviewers

Groups

reviewboard

People

Description

This moves a handful of models and views specific to the Review Request

page into the new review-request-page JavaScript bundle. These models

and views aren't used in any other page, so getting them out of the

reviews bundle will help slim down the other pages and keep the code

more focused.
The models and views themselves now live in the RB.ReviewRequestPage

namespace.
Aside from updating namespace references, the files are not changed.

There's no conversion to ES6 or documentation updating, for instance, in

this change.

Testing Done

Unit tests all pass and all files were found.

Tested all applicable functionality of the review request page, including:

Replying to comments
Publishing replies
Interacting with reviews and changes

Issues

Description	From	Last Updated
E501 line too long (82 > 79 characters)	reviewbot	July 20, 2017, 2:35 a.m.
E501 line too long (85 > 79 characters)	reviewbot	July 20, 2017, 2:35 a.m.
E501 line too long (80 > 79 characters)	reviewbot	July 20, 2017, 2:35 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c21819c)