• 
      

    Move more JavaScript for the review request page to the new bundle.

    Review Request #9093 — Created July 20, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    9558177...

    Reviewers

    This moves a handful of models and views specific to the Review Request
    page into the new review-request-page JavaScript bundle. These models
    and views aren't used in any other page, so getting them out of the
    reviews bundle will help slim down the other pages and keep the code
    more focused.

    The models and views themselves now live in the RB.ReviewRequestPage
    namespace.

    Aside from updating namespace references, the files are not changed.
    There's no conversion to ES6 or documentation updating, for instance, in
    this change.

    Unit tests all pass and all files were found.

    Tested all applicable functionality of the review request page, including:

    • Replying to comments
    • Publishing replies
    • Interacting with reviews and changes
    Description From Last Updated

    E501 line too long (82 > 79 characters)

    reviewbotreviewbot

    E501 line too long (85 > 79 characters)

    reviewbotreviewbot

    E501 line too long (80 > 79 characters)

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (c21819c)