Refactor Djblets.Config into ES6

Review Request #9073 - Created July 13, 2017 and submitted

Barret Rennie
Djblets
release-0.10.x
9075
6af029a...
djblets

This patch updates the Djblets.Config js to ES6 and updates and adds
documentation where missing.

Ran JS tests.

  • 0
  • 0
  • 18
  • 0
  • 18
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

Barret Rennie
Barret Rennie
David Trowbridge
  1. I didn't get very far before the diff got hard to read. Would you mind re-posting a hand-made diff with a lower threshold for rename detection?

  2. 
      
Barret Rennie
David Trowbridge
  1. 
      
  2. djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Can we alphabetize these?

  3. djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Alphabetize?

  4. These are indented too much.

  5. Fix up comments in this file?

  6. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (2cce538)
Loading...