Summary

Refactor Djblets.Config into ES6

Review Request #9073 — Created July 13, 2017 and submitted July 17, 2017, 2:12 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

9075

Commit

6af029a...

Reviewers

Groups

djblets

People

Description

This patch updates the Djblets.Config js to ES6 and updates and adds
documentation where missing.

Testing Done

Ran JS tests.

Issues

Description	From	Last Updated
Col: 57 Unnecessary semicolon.	reviewbot	July 13, 2017, 2:51 p.m.
Typoe	david	July 14, 2017, 5:10 p.m.
Can we alphabetize these?	david	July 14, 2017, 5:12 p.m.
Alphabetize?	david	July 14, 2017, 5:12 p.m.
Too many blank lines.	david	July 14, 2017, 5:13 p.m.
/**	david	July 14, 2017, 5:13 p.m.
Missing Args	david	July 14, 2017, 5:13 p.m.
Use a template string?	david	July 14, 2017, 5:14 p.m.
, optional	david	July 14, 2017, 5:18 p.m.
/**	david	July 14, 2017, 5:18 p.m.
, optional	david	July 14, 2017, 5:18 p.m.
These are indented too much.	david	July 14, 2017, 5:18 p.m.
, optional	david	July 14, 2017, 5:18 p.m.
/**	david	July 14, 2017, 5:19 p.m.
/**	david	July 14, 2017, 5:19 p.m.
Imperative mood.	david	July 14, 2017, 5:19 p.m.
Missing Returns	david	July 14, 2017, 5:19 p.m.
Fix up comments in this file?	david	July 14, 2017, 5:20 p.m.

flake8 passed.

JSHint failed.

JSHint

djblets/static/djblets/js/configForms/views/listItemView.es6.js (Diff revision 1)
Show all issues
```
Col: 57
 Unnecessary semicolon.
```

Change Summary:

jshint

Commit:

-	1d0dc88f786efae6d744c779fd366ef405d9c819
+	607d9b86f461c616dd86b1207a5a40803429b0b6

Diff:

Revision 2 (+964 -865)

Show changes

	djblets/staticbundles.py
	djblets/static/djblets/js/configForms/collections/listItemsCollection.js
	djblets/static/djblets/js/configForms/models/listItemModel.js
	djblets/static/djblets/js/configForms/models/listItemModel.es6.js
	djblets/static/djblets/js/configForms/models/listModel.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.es6.js
	djblets/static/djblets/js/configForms/views/listItemView.js
	10 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commit:

-	607d9b86f461c616dd86b1207a5a40803429b0b6
+	6af029a552abbe0ee4bf9d7ca64dfa93611d41b2

Diff:

Revision 3 (+964 -863)

Show changes

	djblets/staticbundles.py
	djblets/static/djblets/js/configForms/collections/listItemsCollection.js
	djblets/static/djblets/js/configForms/models/listItemModel.js
	djblets/static/djblets/js/configForms/models/listItemModel.es6.js
	djblets/static/djblets/js/configForms/models/listModel.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.es6.js
	djblets/static/djblets/js/configForms/views/listItemView.js
	10 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

I didn't get very far before the diff got hard to read. Would you mind re-posting a hand-made diff with a lower threshold for rename detection?

djblets/static/djblets/js/configForms/collections/listItemsCollection.es6.js (Diff revision 3)
Show all issues
```
Typoe
```

Change Summary:

repost with diff -M0.05

Diff:

Revision 4 (+683 -582)

Show changes

	djblets/staticbundles.py
	djblets/static/djblets/js/configForms/collections/listItemsCollection.js
	djblets/static/djblets/js/configForms/models/listItemModel.js
	djblets/static/djblets/js/configForms/models/listModel.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.js
	djblets/static/djblets/js/configForms/views/listItemView.js
	djblets/static/djblets/js/configForms/views/listView.js
	djblets/static/djblets/js/configForms/views/pagesView.js
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)

Show all issues

Can we alphabetize these?

djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)

Show all issues

Alphabetize?

djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)
Show all issues
```
Too many blank lines.
```
djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)
Show all issues
```
/**
```
djblets/static/djblets/js/configForms/models/listItemModel.es6.js (Diff revision 4)
Show all issues
```
Missing Args
```
djblets/static/djblets/js/configForms/views/listItemView.es6.js (Diff revision 4)
Show all issues
```
Use a template string?
```
djblets/static/djblets/js/configForms/views/listView.es6.js (Diff revision 4)
Show all issues
```
, optional
```
djblets/static/djblets/js/configForms/views/listView.es6.js (Diff revision 4)
Show all issues
```
/**
```
djblets/static/djblets/js/configForms/views/listView.es6.js (Diff revision 4)
Show all issues
```
, optional
```
djblets/static/djblets/js/configForms/views/listView.es6.js (Diff revision 4)
Show all issues
```
These are indented too much.
```
djblets/static/djblets/js/configForms/views/listView.es6.js (Diff revision 4)
Show all issues
```
, optional
```
djblets/static/djblets/js/configForms/views/tableItemView.es6.js (Diff revision 4)
Show all issues
```
/**
```
djblets/static/djblets/js/configForms/views/tableItemView.es6.js (Diff revision 4)
Show all issues
```
/**
```
djblets/static/djblets/js/configForms/views/tableItemView.es6.js (Diff revision 4)
Show all issues
```
Imperative mood.
```
djblets/static/djblets/js/configForms/views/tableItemView.es6.js (Diff revision 4)
Show all issues
```
Missing Returns
```
djblets/static/djblets/js/configForms/views/tableView.es6.js (Diff revision 4)
Show all issues
```
Fix up comments in this file?
```

Change Summary:

Addressed David's issues.

Diff:

Revision 5 (+723 -596)

Show changes

	djblets/staticbundles.py
	djblets/static/djblets/js/configForms/collections/listItemsCollection.js
	djblets/static/djblets/js/configForms/models/listItemModel.js
	djblets/static/djblets/js/configForms/models/listModel.js
	djblets/static/djblets/js/configForms/models/tests/listItemModelTests.js
	djblets/static/djblets/js/configForms/views/listItemView.js
	djblets/static/djblets/js/configForms/views/listView.js
	djblets/static/djblets/js/configForms/views/pagesView.js
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (2cce538)