Summary

Support OAuth2 authorization and authentication to Web API

Review Request #9072 — Created July 12, 2017 and submitted July 21, 2017, 1:36 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~9030~~, ~~9071~~

Blocks

9078

Commit

8ada670...

Reviewers

Groups

reviewboard

People

Description

This patch brings full OAuth2 support into Review Board. We now support
authorization via a new endpoint (/oauth2/authorize/) which clients
can use in the process of getting an OAuth2 token to authenticate
themselves to the Web API.

Testing Done


Created a sample OAuth client and retrieved an OAuth2 token. Used it

  to communicate with the web API.
Ran unit tests.

Issues

Description	From	Last Updated
F401 'oauth2_provider.models.AccessToken' imported but unused	reviewbot	July 13, 2017, 3:59 p.m.
Can scopes_descriptions be empty?	david	July 20, 2017, 1:27 p.m.
Mark for translation?	david	July 20, 2017, 1:29 p.m.
Docstring?	david	July 20, 2017, 1:34 p.m.
features before testing	david	July 20, 2017, 1:34 p.m.
Can we have oauth before s?	david	July 21, 2017, 1:33 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_oauth2_auth.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'oauth2_provider.models.AccessToken' imported but unused
```

Change Summary:

Flake8

Diff:

Revision 2 (+430 -11)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/admin/siteconfig.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/apps.py
	reviewboard/oauth/urls.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/templates/oauth/authorize.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Can scopes_descriptions be empty?
```
reviewboard/templates/oauth/authorize.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Mark for translation?
```
reviewboard/webapi/auth_backends.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Docstring?
```
reviewboard/webapi/tests/test_oauth2_auth.py (Diff revision 2)
The issue has been resolved. Show all issues
```
features before testing
```

Change Summary:

Address David's issues

Diff:

Revision 3 (+458 -11)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/admin/siteconfig.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/apps.py
	reviewboard/oauth/urls.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/urls.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Can we have oauth before s?
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (57b10f7)

reviewboard/urls.py (Diff revision 3)