Inform users of security issues and regenerate client secrets from UI

Review Request #9071 — Created July 12, 2017 and submitted

Information

Review Board
release-3.0.x
0beef29...

Reviewers

The Application forms can now regenerate the client secret view a new
OAuthSecretInputWidget, which makes an API call to regenerate the
client secret of the associated widget. Doing so will clear the flag
that marks applications as "disbled for security" and they can be
subsequently enabled.

Additionally, such disabled apps now have a warning present on the
application management screen. Regular disabled apps are displayed with
an italic font.

  • Ran unit tests.
  • Regenerated client secrets and saw I was able to enable applications
    that were disabled due to security concerns.

Description From Last Updated

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E501 line too long (107 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

Col: 7 'clientSecretText' is defined but never used.

reviewbotreviewbot

Col: 136 Missing semicolon.

reviewbotreviewbot

Col: 135 Expected an assignment or function call and instead saw an expression.

reviewbotreviewbot

Col: 11 Missing semicolon.

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E501 line too long (107 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

Col: 7 'clientSecretText' is defined but never used.

reviewbotreviewbot

Col: 135 Expected an assignment or function call and instead saw an expression.

reviewbotreviewbot

Col: 136 Missing semicolon.

reviewbotreviewbot

Col: 11 Missing semicolon.

reviewbotreviewbot

E501 line too long (107 > 79 characters)

reviewbotreviewbot

E501 line too long (107 > 79 characters)

reviewbotreviewbot

Can't use trailing commas in ES5 code.

daviddavid
Checks run (2 failed)
flake8 failed.
JSHint failed.

flake8

JSHint

brennie
Review request changed
Change Summary:

Added unit test

Commit:
7c0725c1156b7f8d1d367af6ec4747b3e1798f66
feb3743d0b319abace981a8f025233cf6790b313

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

brennie
Review request changed
Change Summary:

jshint, flake8

Commit:
feb3743d0b319abace981a8f025233cf6790b313
0beef29ece8683530e76624d979a34da65a26449

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

brennie
Review request changed
Change Summary:

Refactor out the render() stuff to use the new Djblets.Config.ListItemView.prototype.getRenderContext

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. Show all issues

    Can't use trailing commas in ES5 code.

  3. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (7699460)