Inform users of security issues and regenerate client secrets from UI
Review Request #9071 — Created July 12, 2017 and submitted
The Application forms can now regenerate the client secret view a new
OAuthSecretInputWidget
, which makes an API call to regenerate the
client secret of the associated widget. Doing so will clear the flag
that marks applications as "disbled for security" and they can be
subsequently enabled.Additionally, such disabled apps now have a warning present on the
application management screen. Regular disabled apps are displayed with
an italic font.
- Ran unit tests.
- Regenerated client secrets and saw I was able to enable applications
that were disabled due to security concerns.
Description | From | Last Updated |
---|---|---|
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (107 > 79 characters) |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
Col: 7 'clientSecretText' is defined but never used. |
reviewbot | |
Col: 136 Missing semicolon. |
reviewbot | |
Col: 135 Expected an assignment or function call and instead saw an expression. |
reviewbot | |
Col: 11 Missing semicolon. |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E501 line too long (107 > 79 characters) |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
Col: 7 'clientSecretText' is defined but never used. |
reviewbot | |
Col: 135 Expected an assignment or function call and instead saw an expression. |
reviewbot | |
Col: 136 Missing semicolon. |
reviewbot | |
Col: 11 Missing semicolon. |
reviewbot | |
E501 line too long (107 > 79 characters) |
reviewbot | |
E501 line too long (107 > 79 characters) |
reviewbot | |
Can't use trailing commas in ES5 code. |
david |
- Change Summary:
-
Added unit test
- Commit:
-
7c0725c1156b7f8d1d367af6ec4747b3e1798f66feb3743d0b319abace981a8f025233cf6790b313
- Diff:
-
Revision 2 (+366 -9)
Checks run (2 failed)
flake8
JSHint
- Change Summary:
-
jshint, flake8
- Commit:
-
feb3743d0b319abace981a8f025233cf6790b3130beef29ece8683530e76624d979a34da65a26449
- Diff:
-
Revision 3 (+365 -9)
- Change Summary:
-
Refactor out the render() stuff to use the new
Djblets.Config.ListItemView.prototype.getRenderContext
- Depends On:
-
- Diff:
Revision 4 (+355 -9)