Summary

Inform users of security issues and regenerate client secrets from UI

Review Request #9071 — Created July 11, 2017 and submitted July 17, 2017, 2:16 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~9075~~

Blocks

9072

Commit

0beef29...

Reviewers

Groups

reviewboard

People

Description

The Application forms can now regenerate the client secret view a new
OAuthSecretInputWidget, which makes an API call to regenerate the
client secret of the associated widget. Doing so will clear the flag
that marks applications as "disbled for security" and they can be
subsequently enabled.

Additionally, such disabled apps now have a warning present on the
application management screen. Regular disabled apps are displayed with
an italic font.

Testing Done


Ran unit tests.
Regenerated client secrets and saw I was able to enable applications

  that were disabled due to security concerns.

Files

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:32 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:32 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:34 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
Col: 7 'clientSecretText' is defined but never used.	reviewbot	July 11, 2017, 11:34 p.m.
Col: 136 Missing semicolon.	reviewbot	July 11, 2017, 11:32 p.m.
Col: 135 Expected an assignment or function call and instead saw an expression.	reviewbot	July 11, 2017, 11:32 p.m.
Col: 11 Missing semicolon.	reviewbot	July 11, 2017, 11:34 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:33 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:34 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:34 p.m.
W293 blank line contains whitespace	reviewbot	July 11, 2017, 11:34 p.m.
Col: 7 'clientSecretText' is defined but never used.	reviewbot	July 11, 2017, 11:33 p.m.
Col: 135 Expected an assignment or function call and instead saw an expression.	reviewbot	July 11, 2017, 11:33 p.m.
Col: 136 Missing semicolon.	reviewbot	July 11, 2017, 11:33 p.m.
Col: 11 Missing semicolon.	reviewbot	July 11, 2017, 11:33 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 12, 2017, 1:41 p.m.
E501 line too long (107 > 79 characters)	reviewbot	July 13, 2017, 5 p.m.
Can't use trailing commas in ES5 code.	david	July 17, 2017, 2:09 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/oauth/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

JSHint

reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 7
 'clientSecretText' is defined but never used.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 136
 Missing semicolon.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 135
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthClientSecretView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 11
 Missing semicolon.
```

Change Summary:

Added unit test

Commit:

7c0725c1156b7f8d1d367af6ec4747b3e1798f66

feb3743d0b319abace981a8f025233cf6790b313

Diff:

Revision 2 (+366 -9)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/forms/pages.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/tests.py
	reviewboard/oauth/widgets.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/static/rb/css/pages/my-account.less
	reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js
	5 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/oauth/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (107 > 79 characters)
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/oauth/widgets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

JSHint

reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 7
 'clientSecretText' is defined but never used.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 135
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 136
 Missing semicolon.
```
reviewboard/static/rb/js/accountPrefsPage/views/oauthClientSecretView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 11
 Missing semicolon.
```

Change Summary:

jshint, flake8

Commit:

feb3743d0b319abace981a8f025233cf6790b313

0beef29ece8683530e76624d979a34da65a26449

Diff:

Revision 3 (+365 -9)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/forms/pages.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/tests.py
	reviewboard/oauth/widgets.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/static/rb/css/pages/my-account.less
	reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js
	5 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/oauth/widgets.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (107 > 79 characters)
```

Change Summary:

Refactor out the render() stuff to use the new Djblets.Config.ListItemView.prototype.getRenderContext

Depends On:

~~9075 - Support rendering with additional context in Config.ListItemView~~

Diff:

Revision 4 (+355 -9)

Show changes

	reviewboard/staticbundles.py
	reviewboard/accounts/forms/pages.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/tests.py
	reviewboard/oauth/widgets.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/static/rb/css/pages/my-account.less
	reviewboard/static/rb/js/accountPrefsPage/views/oauthApplicationsView.es6.js
	5 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/oauth/widgets.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (107 > 79 characters)
```

Ship it!

reviewboard/templates/oauth/secret_input_widget.html (Diff revision 4)
The issue has been resolved. Show all issues
```
Can't use trailing commas in ES5 code.
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (7699460)

reviewboard/oauth/forms.py (Diff revision 1)

reviewboard/oauth/forms.py (Diff revision 1)

reviewboard/oauth/forms.py (Diff revision 1)

reviewboard/oauth/forms.py (Diff revision 2)