Fix for rbt post command hangs issue ,while posting the review request on clearcase branch

Review Request #9069 - Created July 11, 2017 and updated

Rishikesh Gupta
RBTools
master
4547
e0b6c74...
rbtools

While posting review request from rbtools on clearcase branch , rbt post command hangs for infinite time , So changes made on file 'rbtools/utils/process.py' : used p.communiacte() instead of p.stdout.readline().



  • 0
  • 0
  • 16
  • 0
  • 16
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

Rishikesh Gupta
Barret Rennie
  1. C

  2. Can you add the ticket # (4547) to the bugs field?

  3. Can you flesh out the summary and description? Neither need to include the bug #.

    See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ for information we expect in patches

    1. summary and description has been modified accordingly.

  4. rbtools/utils/process.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     

    We generally order stuff like:

    if positive_case:
        ...
    else:
        ...
    
    1. positive_case already in IF block.

    2. What he means is we prefer:

      if with_errors:
          ...
      else:
          ...
      

      It's just slightly simpler to read that way.

    3. done

  5. 
      
Rishikesh Gupta
David Trowbridge
  1. 
      
  2. Please detail to us what you've done to test this change.

    1. Used clearcase dynamic view .
      Command : rbt post -d --summary="sssssss" --description="ddddd" brtype:xxxxx_bfw_fff_drop2
      This command hang before fixes .
      After doing fixes in process.py file ,
      Above command worked fine.

  3. 
      
Rishikesh Gupta
David Trowbridge
  1. I'm sorry for the long delay on this. It got buried on my dashboard and I lost track of it.

    Can you detail what you've done to test this change?

    1. Used clearcase dynamic view .
      Command : rbt post -d --summary="sssssss" --description="ddddd" brtype:xxxxx_bfw_fff_drop2
      This command hang before fixes in process.py .
      After doing fixes in process.py file , Above command worked fine.

  2. rbtools/utils/process.py (Diff revision 3)
     
     

    This no longer does the right thing when with_errors=False and split_lines=True.

  3. 
      
Rishikesh Gupta
Review request changed

Commit:

-803ad942c2faae065a10475d1972ee68615a1eb2
+f0c54e5484853a1761c6e1b21e31cfe75c286874

Diff:

Revision 4 (+5 -8)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

Rishikesh Gupta
Review request changed

Commit:

-f0c54e5484853a1761c6e1b21e31cfe75c286874
+e0b6c744a3449ddb311b5d4a15f4ee4447cdf6ff

Diff:

Revision 5 (+3 -6)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...