flake8
-
rbtools/utils/process.py (Diff revision 1) Show all issues -
-
-
rbtools/utils/process.py (Diff revision 1) E712 comparison to False should be 'if cond is False:' or 'if not cond:'
-
Review Request #9069 — Created July 11, 2017 and discarded
While posting review request from rbtools on clearcase branch , rbt post command hangs for infinite time , So changes made on file 'rbtools/utils/process.py' : used p.communiacte() instead of p.stdout.readline().
Description | From | Last Updated |
---|---|---|
Can you add the ticket # (4547) to the bugs field? |
brennie | |
Can you flesh out the summary and description? Neither need to include the bug #. See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ for information we … |
brennie | |
Please detail to us what you've done to test this change. |
david | |
W293 blank line contains whitespace |
reviewbot | |
W191 indentation contains tabs |
reviewbot | |
E101 indentation contains mixed spaces and tabs |
reviewbot | |
E712 comparison to False should be 'if cond is False:' or 'if not cond:' |
reviewbot | |
E203 whitespace before ',' |
reviewbot | |
We generally order stuff like: if positive_case: ... else: ... |
brennie | |
This no longer does the right thing when with_errors=False and split_lines=True. |
david | |
W293 blank line contains whitespace |
reviewbot | |
E101 indentation contains mixed spaces and tabs |
reviewbot | |
W191 indentation contains tabs |
reviewbot | |
W293 blank line contains whitespace |
reviewbot | |
E101 indentation contains mixed spaces and tabs |
reviewbot | |
W191 indentation contains tabs |
reviewbot |
rbtools/utils/process.py (Diff revision 1) |
---|
rbtools/utils/process.py (Diff revision 1) |
---|
E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+8 -11) |
C
Can you flesh out the summary and description? Neither need to include the bug #.
See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ for information we expect in patches
rbtools/utils/process.py (Diff revision 2) |
---|
We generally order stuff like:
if positive_case: ... else: ...
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Bugs: |
|
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+8 -11) |
I'm sorry for the long delay on this. It got buried on my dashboard and I lost track of it.
Can you detail what you've done to test this change?
rbtools/utils/process.py (Diff revision 3) |
---|
This no longer does the right thing when
with_errors=False
andsplit_lines=True
.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+5 -8) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+3 -6) |