This change has been discarded.

Describe the reason it's discarded (optional):

Fix included in master (f158f41).

Summary

Fix for rbt post command hangs issue ,while posting the review request on clearcase branch

Review Request #9069 — Created July 11, 2017 and discarded 7 years, 2 months ago

Information

Owner

rishikesh.gupta*

Repository

RBTools

Branch

master

Bugs

4547

Depends On

Reviewers

Groups

rbtools

People

Description*

While posting review request from rbtools on clearcase branch , rbt post command hangs for infinite time , So changes made on file 'rbtools/utils/process.py' : used p.communiacte() instead of p.stdout.readline().

Testing Done

Issues

Description	From	Last Updated
Can you add the ticket # (4547) to the bugs field?	brennie	7 years, 8 months ago
Can you flesh out the summary and description? Neither need to include the bug #. See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ for information we …	brennie	7 years, 8 months ago
Please detail to us what you've done to test this change.	david	7 years, 7 months ago
W293 blank line contains whitespace	reviewbot	7 years, 9 months ago
W191 indentation contains tabs	reviewbot	7 years, 9 months ago
E101 indentation contains mixed spaces and tabs	reviewbot	7 years, 9 months ago
E712 comparison to False should be 'if cond is False:' or 'if not cond:'	reviewbot	7 years, 9 months ago
E203 whitespace before ','	reviewbot	7 years, 9 months ago
We generally order stuff like: if positive_case: ... else: ...	brennie	7 years, 7 months ago
This no longer does the right thing when with_errors=False and split_lines=True.	david	7 years, 3 months ago
W293 blank line contains whitespace	reviewbot	7 years, 3 months ago
E101 indentation contains mixed spaces and tabs	reviewbot	7 years, 3 months ago
W191 indentation contains tabs	reviewbot	7 years, 3 months ago
W293 blank line contains whitespace	reviewbot	7 years, 3 months ago
E101 indentation contains mixed spaces and tabs	reviewbot	7 years, 3 months ago
W191 indentation contains tabs	reviewbot	7 years, 3 months ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E712 comparison to False should be 'if cond is False:' or 'if not cond:'
```
rbtools/utils/process.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E203 whitespace before ','
```

Commit:

43d730b1a75166c5edc2c76d0be1ff833c8e5c45

Diff:

Revision 2 (+8 -11)

Show changes

rbtools/utils/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

```
C
```
The issue has been resolved. Show all issues
```
Can you add the ticket # (4547) to the bugs field?
```
1. RI
  
  rishikesh.gupta 7 years, 8 months ago
  added

The issue has been resolved. Show all issues

Can you flesh out the summary and description? Neither need to include the bug #.

See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/ for information we expect in patches

rishikesh.gupta 7 years, 8 months ago

summary and description has been modified accordingly.

rbtools/utils/process.py (Diff revision 2)

The issue has been resolved. Show all issues

We generally order stuff like:

if positive_case:
    ...
else:
    ...

RI

rishikesh.gupta 7 years, 8 months ago
```
positive_case already in IF block.
```

david 7 years, 8 months ago

What he means is we prefer:

if with_errors:
    ...
else:
    ...

It's just slightly simpler to read that way.

RI

rishikesh.gupta 7 years, 7 months ago
```
done
```

Summary:: Fix for bug 4547:rbt post command hangs while using with Clearcase to post code on a branch
Fix for rbt post command hangs issue ,while posting the review request on clearcase branch
Description:: ~
https://hellosplat.com/s/beanbag/tickets/4547/
~
While posting review request from rbtools on clearcase branch , rbt post command hangs for infinite time , So changes made on file 'rbtools/utils/process.py' : used p.communiacte() instead of p.stdout.readline().
Bugs:: 4547

The issue has been resolved. Show all issues

Please detail to us what you've done to test this change.

rishikesh.gupta 7 years, 7 months ago

Used clearcase dynamic view .
Command : rbt post -d --summary="sssssss" --description="ddddd" brtype:xxxxx_bfw_fff_drop2
This command hang before fixes .
After doing fixes in process.py file ,
Above command worked fine.

Commit:

43d730b1a75166c5edc2c76d0be1ff833c8e5c45

803ad942c2faae065a10475d1972ee68615a1eb2

Diff:

Revision 3 (+8 -11)

Show changes

rbtools/utils/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

I'm sorry for the long delay on this. It got buried on my dashboard and I lost track of it.

Can you detail what you've done to test this change?

rishikesh.gupta 7 years, 3 months ago

Used clearcase dynamic view .
Command : rbt post -d --summary="sssssss" --description="ddddd" brtype:xxxxx_bfw_fff_drop2
This command hang before fixes in process.py .
After doing fixes in process.py file , Above command worked fine.

rbtools/utils/process.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This no longer does the right thing when with_errors=False and split_lines=True.
```
1. RI
  
  rishikesh.gupta 7 years, 3 months ago
  ok

Commit:

803ad942c2faae065a10475d1972ee68615a1eb2

f0c54e5484853a1761c6e1b21e31cfe75c286874

Diff:

Revision 4 (+5 -8)

Show changes

rbtools/utils/process.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
rbtools/utils/process.py (Diff revision 4)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```

Commit:

f0c54e5484853a1761c6e1b21e31cfe75c286874

e0b6c744a3449ddb311b5d4a15f4ee4447cdf6ff

Diff:

Revision 5 (+3 -6)

Show changes

rbtools/utils/process.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status:: Discarded
Change Summary:: Fix included in master (f158f41).

~		https://hellosplat.com/s/beanbag/tickets/4547/
	~	While posting review request from rbtools on clearcase branch , rbt post command hangs for infinite time , So changes made on file 'rbtools/utils/process.py' : used p.communiacte() instead of p.stdout.readline().