flake8
passed.
JSHint
passed.
Do not update timestamp when revoking Ship Its
Review Request #9068 — Created July 10, 2017 and submitted
Previously, revoking a Ship It would cause the timestamp of the review
to be updated, which resulted in the comments on a review request going
out of order. This was because we were not passing keyword arguments
fromReview.saveto its parent method. This is now fixed and unit
tests have been added to ensure the behaviour does not regress.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
The diff here includes a bunch of unrelated changes. Please re-post with the right branch(es). |
 david
|
|
|
I don't understand why this is needed, given the implementation of both functions? |
 chipx86
|
|
|
Can we import just the function we need? |
chipx86
|
|
|
"constant" Maybe ".. with a constant in a spy below"? |
chipx86
|
|
|
Same as above. |
chipx86
|
-
-
reviewboard/reviews/tests/test_review.py (Diff revision 1) I don't understand why this is needed, given the implementation of both functions?
-
Change Summary:
Addressed Christian's issues.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+399 -98) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/reviews/tests/test_review.py (Diff revision 3) "constant"
Maybe ".. with a constant in a spy below"?
-
Change Summary:
Addressed Christian's issues
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+111 -8) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.