Do not update timestamp when revoking Ship Its

Review Request #9068 - Created July 10, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
fe88e6d...
reviewboard

Previously, revoking a Ship It would cause the timestamp of the review
to be updated, which resulted in the comments on a review request going
out of order. This was because we were not passing keyword arguments
from Review.save to its parent method. This is now fixed and unit
tests have been added to ensure the behaviour does not regress.

Ran unit tests.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Christian Hammond
  1. 
      
  2. reviewboard/reviews/tests/test_review.py (Diff revision 1)
     
     
     

    I don't understand why this is needed, given the implementation of both functions?

  3. reviewboard/webapi/tests/test_review.py (Diff revision 1)
     
     

    Can we import just the function we need?

  4. 
      
Barret Rennie
David Trowbridge
  1. 
      
  2. The diff here includes a bunch of unrelated changes. Please re-post with the right branch(es).

  3. 
      
Barret Rennie
Christian Hammond
  1. 
      
  2. "constant"

    Maybe ".. with a constant in a spy below"?

  3. reviewboard/webapi/tests/test_review.py (Diff revision 3)
     
     

    Same as above.

  4. 
      
Barret Rennie
Christian Hammond
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (473ac6c)
Loading...