Fix diffs for ClearCaseClient under Win XP

Review Request #906 — Created June 25, 2009 and discarded

Information
Owner:	bartek
Repository:	Review Board SVN (deprecated)
Branch:
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

I have changed few things to make this work under windows. I have not tested this under Linux or anything else than WinXp...

Testing Done

No real world testing but the diff was generated (checked with -n option)

The split_lines change is definitely needed, and we've verified this works locally.

/trunk/rbtools/scripts/post-review (Diff revision 1)

I'm not sure why you need this. Are you running under Vista or Windows 7, by any chance?

djs July 10, 2009, 5:43 a.m.

I probably should have read the title of your review before asking this question :)

bartek July 17, 2009, 5:53 a.m.

I've got a problem with removing temporary files. I am not sure why they were created read-only. It shouldn't make a difference in case they are rw, I guess.

/trunk/rbtools/scripts/post-review (Diff revision 1)
```
Should be alphabetical.
```

/trunk/rbtools/scripts/post-review (Diff revision 1)

Can you add a comment explaining what this does?

bartek July 17, 2009, 5:54 a.m.

I will add a comment. The explanation as in comment from Dan.

/trunk/rbtools/scripts/post-review (Diff revision 1)
```
And this.
```

You have a pending review.

Review Board 4.0.5 alpha 0 (dev)

Fix diffs for ClearCaseClient under Win XP