• 
      

    Modernize account page tests

    Review Request #9059 — Created July 7, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    f67edba...

    Reviewers

    When adding the OAuth2 apps page, I neglected to update the account page
    tests to account for the new page. While updating these tests, I
    replaced the hardcoded strings of page IDs with fetching the default
    page classes from the registry itself and updated all the tests to do
    set comparisons instead of length comparisons, which did not indicate
    why a test was failing, only that it was.

    With this modernization, these tests shouldn't break in the future when
    the set of pages changes.

    Ran unit tests.

    Description From Last Updated

    F841 local variable 'page_classes' is assigned to but never used

    reviewbotreviewbot

    What's up with the extra parens?

    daviddavid
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    brennie
    david
    1. 
        
    2. reviewboard/accounts/tests.py (Diff revision 2)
       
       
      Show all issues

      What's up with the extra parens?

    3. 
        
    brennie
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (d6d92dd)