Modernize account page tests

Review Request #9059 — Created July 7, 2017 and submitted

Barret Rennie
Review Board

When adding the OAuth2 apps page, I neglected to update the account page
tests to account for the new page. While updating these tests, I
replaced the hardcoded strings of page IDs with fetching the default
page classes from the registry itself and updated all the tests to do
set comparisons instead of length comparisons, which did not indicate
why a test was failing, only that it was.

With this modernization, these tests shouldn't break in the future when
the set of pages changes.

Ran unit tests.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.


Barret Rennie
David Trowbridge
  2. reviewboard/accounts/ (Diff revision 2)

    What's up with the extra parens?

Barret Rennie
David Trowbridge
  1. Ship It!
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (d6d92dd)