Summary

Allow filter_fieldsets to take either ModelAdmin or fieldsets directly

Review Request #9053 — Created July 5, 2017 and submitted July 7, 2017, 4:31 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

9056

Commit

50f66b3...

Reviewers

Groups

djblets

People

Description

Previously, you had to specify the actual ModelAdmin class to retrieve

fieldsets from. This is no longer the case and the fieldsets themselves

can be passed instead.
The documentation for what the function does has also been improved.

Testing Done

Tested with /r/9056/.

Issues

Description	From	Last Updated
The latest diff revision seems to include some other changes.	david	July 7, 2017, 2:39 p.m.
W293 blank line contains whitespace	reviewbot	July 5, 2017, 10:03 p.m.
W293 blank line contains whitespace	reviewbot	July 5, 2017, 10:03 p.m.
ValueError is probably appropriate here.	david	July 6, 2017, 3:35 p.m.
We should probably verify that admin.fieldsets exists and is iterable.	david	July 6, 2017, 3:35 p.m.
It's probably slightly better to use hasattr here.	david	July 7, 2017, 4:28 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/forms/fieldsets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/fieldsets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

Flake 8 Fixups

Diff:

Revision 2 (+21 -10)

Show changes

djblets/forms/fieldsets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/forms/fieldsets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
ValueError is probably appropriate here.
```
djblets/forms/fieldsets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We should probably verify that admin.fieldsets exists and is iterable.
```

Change Summary:

Addressed David's issues.

Diff:

Revision 3 (+23 -10)

Show changes

djblets/forms/fieldsets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Some cleanups

Diff:

Revision 4 (+1288 -24)

Show changes

	dev-requirements.txt
	djblets/extensions/manager.py
	djblets/extensions/signals.py
	djblets/webapi/oauth2_scopes.py
	djblets/webapi/auth/backends/base.py
	djblets/webapi/auth/backends/oauth2_tokens.py
	djblets/webapi/resources/mixins/api_tokens.py
	djblets/webapi/resources/mixins/oauth2_tokens.py
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

The latest diff revision seems to include some other changes.

Change Summary:

Post correct branch

Commit:

+	50f66b32048c20017d52813284cb102add8b4bb3

Diff:

Revision 5 (+23 -10)

Show changes

djblets/forms/fieldsets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

djblets/forms/fieldsets.py (Diff revision 5)
The issue has been resolved. Show all issues
```
It's probably slightly better to use hasattr here.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (6c8424f)