flake8
passed.
JSHint
passed.
Rearrange the pages and settings in "My Account".
Review Request #9046 — Created June 29, 2017 and submitted
The various knobs and gewgaws in the account settings had grown organically,
and were kind of a big mess. We had things spread around too many pages and in
somewhat random order.This change rearranges things so that the user profile information comes first
(name, e-mail address, avatar, etc). Next is settings, which includes general
settings and notifications. Groups is moved to be third on the list (instead of
first), and finally the authentication page has the password and API tokens
together.
- Ran unit tests.
- Verified that loading and saving all of the various settings worked correctly.
| Description | From | Last Updated |
|---|---|---|
|
Do you want to change this to look it up in the registry, e.g. builtin_pages = { page.page_id for page … |
 brennie
|
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 2 (+33 -27) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Branch: |
|
||||
|---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 3 (+36 -30) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/accounts/tests.py (Diff revision 3) Do you want to change this to look it up in the registry, e.g.
builtin_pages = { page.page_id for page in AccountPage.registry.get_defaults() }Hardcoding the set of default pages in two places seems less than ideal.