Summary

Rearrange the pages and settings in "My Account".

Review Request #9046 — Created June 29, 2017 and submitted July 14, 2017, 1:54 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

d8fbb3b...

Reviewers

Groups

reviewboard

People

Description

The various knobs and gewgaws in the account settings had grown organically,
and were kind of a big mess. We had things spread around too many pages and in
somewhat random order.

This change rearranges things so that the user profile information comes first
(name, e-mail address, avatar, etc). Next is settings, which includes general
settings and notifications. Groups is moved to be third on the list (instead of
first), and finally the authentication page has the password and API tokens
together.

Testing Done


Ran unit tests.
Verified that loading and saving all of the various settings worked correctly.

Files

Issues

Description	From	Last Updated
Do you want to change this to look it up in the registry, e.g. builtin_pages = { page.page_id for page …	brennie	July 7, 2017, 11:07 a.m.

flake8 passed.

JSHint passed.

Branch:

release-3.0.x

master

Commit:

f32ccc5a84c2567bc0f1f8592cea2c69a4cf262f

688d7ae50d178663754cbc5d0e1336b907d6b9ee

Diff:

Revision 2 (+33 -27)

Show changes

	reviewboard/accounts/pages.py
	reviewboard/accounts/tests.py
	reviewboard/accounts/forms/pages.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Branch:

master

release-3.0.x

Commit:

688d7ae50d178663754cbc5d0e1336b907d6b9ee

d8fbb3bdf900596f9eeb34d68580370c407e3b2c

Diff:

Revision 3 (+36 -30)

Show changes

	reviewboard/accounts/pages.py
	reviewboard/accounts/tests.py
	reviewboard/accounts/forms/pages.py
	reviewboard/notifications/email/message.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
This is a great cleanup!
```

reviewboard/accounts/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

Do you want to change this to look it up in the registry, e.g.

builtin_pages = {
    page.page_id
    for page in AccountPage.registry.get_defaults()
}

Hardcoding the set of default pages in two places seems less than ideal.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (4072b5b)