Summary

Add unit tests for ReviewRequestPageData and the entries.

Review Request #9044 — Created June 29, 2017 and submitted July 7, 2017, 5:43 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

bf9a0c8...

Reviewers

Groups

reviewboard

People

Description

This adds tests that ensure all the data generated by
ReviewRequestPageData is what we'd expect, and that te entries
behave/render correctly.

These tests caught a couple of small issues with status updates (both
data collecting and rendering with URLs without URL text, which have
been fixed in this change.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
F401 'django.contrib.auth.models.User' imported but unused	reviewbot	June 29, 2017, 3:17 a.m.
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused	reviewbot	June 29, 2017, 3:25 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_entries.py (Diff revision 1)
Show all issues
```
F401 'django.contrib.auth.models.User' imported but unused
```

reviewboard/reviews/tests/test_entries.py (Diff revision 1)

Show all issues

F401 'reviewboard.reviews.models.ReviewRequest' imported but unused

Change Summary:


Added a file that didn't get added.
Fixed unused imports.

Commit:

-	54b50b3180f48aea150a0ddffa64f691901885a2
+	bf9a0c8cf6bff230bfe076ebb7aafff11a3b91f6

Diff:

Revision 2 (+711 -4)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_entries.py
	reviewboard/reviews/tests/test_review_request_page_data.py
	reviewboard/templates/reviews/status_update_summary.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (08c1e3e)