Summary

Render ModelAdmin fieldsets outside admin sites

Review Request #9040 — Created June 27, 2017 and submitted July 5, 2017, 2:08 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Blocks

9013

Commit

ab1e430...

Reviewers

Groups

djblets

People

Description

The filer_fieldsets utility function filters a list of fieldsets

from a django.contrib.admin.ModelAdmin so callers rendering forms

can control which fieldsets (such as internal state) are rendered.
This change also refactors the core fieldset rendering of

form_fieldsets.html into its own template so a single fieldset can

be rendered.

Testing Done

Tested with /r/9013/

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	June 27, 2017, 8:54 p.m.
W293 blank line contains whitespace	reviewbot	June 27, 2017, 8:54 p.m.

flake8 passed.

JSHint passed.

Diff:

Revision 2 (+54)

Show changes

	djblets/forms/fieldsets.py
	tests/static/ext/djblets.extensions.templatetags.tests.TestExtension/.version
	tests/static/ext/djblets.extensions.tests.TestExtension/.version

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/forms/fieldsets.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Diff:

Revision 3 (+54)

Show changes

	djblets/forms/fieldsets.py
	tests/static/ext/djblets.extensions.templatetags.tests.TestExtension/.version
	tests/static/ext/djblets.extensions.tests.TestExtension/.version

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/forms/fieldsets.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Commit:

-	9b5f8145acd8cce52fc014df4261d49219fd2ae1
+	ab1e4302017a0bb319efb7933f53aa5fd32f5227

Diff:

Revision 4 (+52)

Show changes

djblets/forms/fieldsets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Diff:

Revision 5 (+66 -13)

Show changes

	djblets/forms/fieldsets.py
	djblets/forms/templates/djblets_forms/admin/form_fieldset.html
	djblets/forms/templates/djblets_forms/admin/form_fieldsets.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		The `get_fieldsets` utility function returns bound form fields from a
~		`django.contrib.admin.ModelAdmin` so they can be rendered outside an
~		admin site.
	~	The `filer_fieldsets` utility function filters a list of fieldsets
	~	`django.contrib.admin.ModelAdmin` so callers rendering forms
	~	can control which fieldsets (such as internal state) are rendered.
	+
	+	This change also refactors the core fieldset rendering of
	+	`form_fieldsets.html` into its own template so a single fieldset can
	+	be rendered.

Diff:

Revision 6 (+66 -13)

Show changes

	djblets/forms/fieldsets.py
	djblets/forms/templates/djblets_forms/admin/form_fieldset.html
	djblets/forms/templates/djblets_forms/admin/form_fieldsets.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Description:

		The `filer_fieldsets` utility function filters a list of fieldsets
~		`django.contrib.admin.ModelAdmin` so callers rendering forms
	~	from a `django.contrib.admin.ModelAdmin` so callers rendering forms
		can control which fieldsets (such as internal state) are rendered.

		This change also refactors the core fieldset rendering of
		`form_fieldsets.html` into its own template so a single fieldset can
		be rendered.

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (c209c2c)

djblets/forms/fieldsets.py (Diff revision 2)

djblets/forms/fieldsets.py (Diff revision 3)