Summary

Fully represent review request entry data using new models.

Review Request #9037 — Created June 26, 2017 and submitted July 7, 2017, 5:43 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

32dc14d...

Reviewers

Groups

reviewboard

People

Description

This change introduces a handful of new JavaScript models for
representing data going into the review request entry boxes (change
descriptions, initial status updates, and reviews). These store the
ReviewRequestEditor used, data on review(s) (for the review box and
status updates), and data on the diff comments (used to load diff
fragments).

The templates for these entries no longer need to call JavaScript
methods, beyond adding the boxes and models. The data is all
self-contained. This will later allow for more easily reloading data for
entries without reloading the entire page.

The new models live in a js/reviewRequestPage/ directory. We'll be able
to move other models/views specific to the review request page here
later on, helping keep things organized.

Testing Done

Unit tests passed.

Tested loading diff comments for reviews (in all boxes) and replying to
them.

Issues

Description	From	Last Updated
Missing the return type.	david	July 5, 2017, 1:27 p.m.
Trailing comma.	david	July 5, 2017, 1:27 p.m.
Missing the return type.	david	July 5, 2017, 1:27 p.m.
Trailing comma.	david	July 5, 2017, 1:27 p.m.
Missing the return type.	david	July 5, 2017, 1:27 p.m.
This would be quite a bit nicer as: reviews = reviewsData.map( reviewData => reviewRequest.createReview( reviewData.id, _.pick(reviewData, 'bodyBottom', 'bodyTop', 'public', 'shipIt')));	david	July 5, 2017, 1:59 p.m.
Trailing comma.	david	July 5, 2017, 1:42 p.m.
Trailing comma.	david	July 5, 2017, 1:42 p.m.
Trailing comma.	david	July 5, 2017, 1:42 p.m.
Trailing comma.	david	July 5, 2017, 1:43 p.m.
diffCommentsData.forEach(diffCommentData => page.queueLoadDiff(diffCommentData[0], diffCommentData[1]));	david	July 5, 2017, 1:59 p.m.
E501 line too long (97 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (91 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (97 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (104 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (80 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (86 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (93 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
E501 line too long (86 > 79 characters)	reviewbot	June 26, 2017, 11:40 p.m.
Col: 2 Expected '}' to match '{' from line 5 and instead saw '%'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 5 Expected ']' to match '[' from line 4 and instead saw 'for'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 9 Expected '}' to match '{' from line 3 and instead saw 'comment'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 50 Expected an identifier and instead saw '}'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 13 Expected an operator and instead saw '['.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 14 Expected ')' and instead saw '{{comment.id}}'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 109 Expected ':' and instead saw ']'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 111 Expected '}' to match '{' from line 7 and instead saw '%'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 113 Expected '}' to match '{' from line 1 and instead saw 'if'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 116 Expected ')' and instead saw 'not'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 120 Expected ')' and instead saw 'forloop'.	reviewbot	June 26, 2017, 11:40 p.m.
Col: 134 Expected an identifier and instead saw '}'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 137 Expected '}' to match '{' from line 7 and instead saw '%'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 137 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 138 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 146 Expected an identifier and instead saw '}'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 146 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 147 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 2 Expected an identifier and instead saw '%'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 2 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 3 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 13 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 13 Expected an identifier and instead saw '}'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 14 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 9 Expected an identifier and instead saw ']'.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 10 Expected an operator and instead saw ','.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 10 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 11 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 32 Expected an assignment or function call and instead saw an expression.	reviewbot	June 26, 2017, 11:41 p.m.
Col: 34 Missing semicolon.	reviewbot	June 26, 2017, 11:41 p.m.
E501 line too long (97 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (91 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (97 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (104 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (80 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (93 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
E501 line too long (86 > 79 characters)	reviewbot	July 5, 2017, 4:24 p.m.
Col: 2 Expected '}' to match '{' from line 5 and instead saw '%'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 5 Expected ']' to match '[' from line 4 and instead saw 'for'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 9 Expected '}' to match '{' from line 3 and instead saw 'comment'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 50 Expected an identifier and instead saw '}'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 13 Expected an operator and instead saw '['.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 14 Expected ')' and instead saw '{{comment.id}}'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 109 Expected ':' and instead saw ']'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 111 Expected '}' to match '{' from line 7 and instead saw '%'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 113 Expected '}' to match '{' from line 1 and instead saw 'if'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 116 Expected ')' and instead saw 'not'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 120 Expected ')' and instead saw 'forloop'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 134 Expected an identifier and instead saw '}'.	reviewbot	July 5, 2017, 4:24 p.m.
Col: 137 Expected '}' to match '{' from line 7 and instead saw '%'.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 137 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 138 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 146 Expected an identifier and instead saw '}'.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 146 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 147 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 2 Expected an identifier and instead saw '%'.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 2 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 3 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 13 Expected an identifier and instead saw '}'.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 13 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 14 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 9 Expected an identifier and instead saw ']'.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 10 Expected an operator and instead saw ','.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 10 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 11 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 32 Expected an assignment or function call and instead saw an expression.	reviewbot	July 5, 2017, 4:25 p.m.
Col: 34 Missing semicolon.	reviewbot	July 5, 2017, 4:25 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (97 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (97 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (104 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (93 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (86 > 79 characters)
```

JSHint

```
Warning: Showing 30 of 33 failures.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 2
 Expected '}' to match '{' from line 5 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 5
 Expected ']' to match '[' from line 4 and instead saw 'for'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected '}' to match '{' from line 3 and instead saw 'comment'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 50
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an operator and instead saw '['.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 14
 Expected ')' and instead saw '{{comment.id}}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 109
 Expected ':' and instead saw ']'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 111
 Expected '}' to match '{' from line 7 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 113
 Expected '}' to match '{' from line 1 and instead saw 'if'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 116
 Expected ')' and instead saw 'not'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 120
 Expected ')' and instead saw 'forloop'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 134
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 137
 Expected '}' to match '{' from line 7 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 137
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 138
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 146
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 146
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 147
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 2
 Expected an identifier and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 2
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 3
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 14
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected an identifier and instead saw ']'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 10
 Expected an operator and instead saw ','.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 10
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 32
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 34
 Missing semicolon.
```

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageEntryModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing the return type.
```
reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageEntryModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing comma.
```

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageReviewEntryModel.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Missing the return type.

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageReviewEntryModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing comma.
```

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageStatusUpdatesEntryModel.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Missing the return type.

reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageStatusUpdatesEntryModel.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

This would be quite a bit nicer as:

reviews = reviewsData.map(
    reviewData => reviewRequest.createReview(
        reviewData.id,
        _.pick(reviewData, 'bodyBottom', 'bodyTop',
               'public', 'shipIt')));

chipx86 July 5, 2017, 1:59 p.m.

_.pick is a pretty slow method. Useful at times when dealing with dynamic lists of keys or when rarely called, but not worth it here, particularly when we know all the data up-front that we care about. It has to loop through each item and then do what this code is doing, but manually.

I'll switch to map, though. That's faster.

https://jsperf.com/map-vs-for-loop-with-pick-vs-manual-building

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewRequestPageChangeEntryModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Trailing comma.

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewRequestPageEntryModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Trailing comma.

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewRequestPageReviewEntryModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Trailing comma.

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewRequestPageStatusUpdatesEntryModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Trailing comma.

reviewboard/static/rb/js/views/reviewView.es6.js (Diff revision 1)

The issue has been dropped. Show all issues


diffCommentsData.forEach(diffCommentData =>
    page.queueLoadDiff(diffCommentData[0], diffCommentData[1]));

chipx86 July 5, 2017, 1:59 p.m.

Standard for loops are a lot faster than .forEach. Going for performance here, too.

https://jsperf.com/for-loop-vs-foreach-with-callback/

Change Summary:


Added missing trailing commas.
Converted a for loop to a map.
Added missing return types in docs.

Commit:

-	a63c421032737cac753a1d84977a62ccc6d0cfe4
+	32dc14ddad0bc5f0bbe509bc0430945262986bdd

Diff:

Revision 2 (+437 -116)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js
	reviewboard/static/rb/js/pages/views/tests/reviewRequestPageViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageChangeEntryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageEntryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageReviewEntryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageStatusUpdatesEntryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewRequestPageChangeEntryModelTests.es6.js
	12 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (97 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (97 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (104 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (93 > 79 characters)
```
reviewboard/staticbundles.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (86 > 79 characters)
```

JSHint

```
Warning: Showing 30 of 33 failures.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 2
 Expected '}' to match '{' from line 5 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 5
 Expected ']' to match '[' from line 4 and instead saw 'for'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 Expected '}' to match '{' from line 3 and instead saw 'comment'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 50
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an operator and instead saw '['.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 14
 Expected ')' and instead saw '{{comment.id}}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 109
 Expected ':' and instead saw ']'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 111
 Expected '}' to match '{' from line 7 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 113
 Expected '}' to match '{' from line 1 and instead saw 'if'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 116
 Expected ')' and instead saw 'not'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 120
 Expected ')' and instead saw 'forloop'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 134
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 137
 Expected '}' to match '{' from line 7 and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 137
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 138
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 146
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 146
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 147
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 2
 Expected an identifier and instead saw '%'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 2
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 3
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an identifier and instead saw '}'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 13
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 14
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 Expected an identifier and instead saw ']'.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 10
 Expected an operator and instead saw ','.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 10
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 32
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/templates/reviews/boxes/review.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 34
 Missing semicolon.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (c2dcb30)