Summary

Disable OAuth2 apps when their owner is removed from the Local Site

Review Request #9033 — Created June 26, 2017 and submitted July 5, 2017, 2:17 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

OAuth2 applications are now disabled when their owner is removed from
the Local Site the application is assigned to. The application will be
reassigned to one of the LocalSite administrators and set to disabled,
which will (once authentication is implemented) prevent the Application
from being used for authentication.

Testing Done


Ran unit tests.
Ran the evolution.

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	June 26, 2017, 5:08 p.m.
W391 blank line at end of file	reviewbot	June 26, 2017, 5:09 p.m.
W391 blank line at end of file	reviewbot	June 26, 2017, 5:09 p.m.
Needs from __future__ import unicode_literals	david	July 4, 2017, 3:52 p.m.
Module docstring?	david	July 4, 2017, 3:52 p.m.
Docstring?	david	July 4, 2017, 3:52 p.m.
E303 too many blank lines (3)	reviewbot	July 4, 2017, 6:38 p.m.
Period outside of the ), I think.	david	July 5, 2017, 2:14 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/oauth/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/site/signal_handlers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Diff:

Revision 2 (+209 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/site/signal_handlers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Diff:

Revision 3 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Diff:

Revision 4 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Diff:

Revision 5 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Diff:

Revision 6 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Diff:

Revision 7 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/site/__init__.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Needs from __future__ import unicode_literals
```
reviewboard/site/signal_handlers.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Module docstring?
```
reviewboard/site/signal_handlers.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Docstring?
```

Change Summary:

Addressed David's issues & simplified

Diff:

Revision 8 (+208 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Addressed David's issues & simplified

Diff:

Revision 9 (+229 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/site/signal_handlers.py (Diff revision 9)
The issue has been resolved. Show all issues
```
E303 too many blank lines (3)
```

Change Summary:

fixups

Diff:

Revision 10 (+228 -1)

Show changes

	reviewboard/oauth/admin.py
	reviewboard/oauth/models.py
	reviewboard/oauth/evolutions/__init__.py
	reviewboard/oauth/evolutions/disabled_for_security.py
	reviewboard/site/__init__.py
	reviewboard/site/signal_handlers.py
	reviewboard/site/tests.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/site/signal_handlers.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Period outside of the ), I think.
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (185651c)

reviewboard/oauth/models.py (Diff revision 1)