Summary

Add a GitHub plan to use another user's repository.

Review Request #9028 — Created June 20, 2017 and discarded Sept. 14, 2021, 11:17 p.m.

Information

Owner

james909fdsa

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Previously, a user could only configure a repository within the user
or an organization. With the addition of this plan, a user will be
able to configure another user's repository by entering the user's
name and desired repository.

The error messages for all plans were also updated by using
dictionaries and %s to get the user's name and repo's name, rather
than outputting a static string.

Testing Done

Ran unit tests with and without parameters, and had no errors.

Manually tested user:chipx86 and repository name:baseconfigs.git,
and it worked with no errors.

When the plan is tested with random inputs for both username and
repo name, we are given the correct error message.

Issues

Description	From	Last Updated
E501 line too long (84 > 79 characters)	reviewbot	June 20, 2017, 5:58 p.m.
E501 line too long (84 > 79 characters)	reviewbot	June 20, 2017, 5:58 p.m.
E303 too many blank lines (2)	reviewbot	June 20, 2017, 5:58 p.m.
Let's use "Owner's username"	chipx86	June 20, 2017, 6:28 p.m.
"org_name" should be "other_username"	chipx86	June 20, 2017, 6:29 p.m.
Should use "other_username" ("username" is one word). Note that this won't apply to the github_other_user_name variables below, because that's actually …	chipx86	June 20, 2017, 6:29 p.m.
"other_username"	chipx86	June 20, 2017, 6:30 p.m.
"Desired" might be confusing to a lot of users, particularly non-English speakers. "Other User's Repository" would be better.	chipx86	June 20, 2017, 6:30 p.m.
"username" isn't right here. Let's use "owner".	chipx86	June 20, 2017, 6:31 p.m.
These can be combined to one line, I believe.	chipx86	June 20, 2017, 6:31 p.m.
No blank line here.	chipx86	June 20, 2017, 6:33 p.m.
Let's extend this to say: " ... was not found, or is not publicly-accessible."	chipx86	June 20, 2017, 6:34 p.m.
No blank line here.	chipx86	June 20, 2017, 6:34 p.m.
No blank line here.	chipx86	June 20, 2017, 6:34 p.m.
These are only relevant to organizations. You don't want them for this plan.	chipx86	June 20, 2017, 6:35 p.m.
Only one blank line here.	chipx86	June 20, 2017, 6:35 p.m.
Can you put each argument on its own line?	chipx86	June 20, 2017, 6:37 p.m.
Let's swap the order of these, so that it'll match the order in which they're presented in the form. This …	chipx86	June 20, 2017, 6:37 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

Testing Done:

		Ran unit tests with and without parameters, and had no errors.
~		It ran 2569 tests in 306.046 seconds.
	~	It ran 2569 tests in 293.380 seconds.

		Manually tested user:chipx86 and repository name:baseconfigs.git,
		and it worked with no errors.

		When the plan is tested with random inputs for both username and
		repo name, we are given the correct error message.

Commit:

-	243c8b08ad064beab34a5dbf027b601e2276ca48
+	ae97f0702c9c41538ff1159f60772e617b699c1f

Diff:

Revision 2 (+124 -24)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/tests/test_github.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's use "Owner's username"
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"org_name" should be "other_username"
```

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

Should use "other_username" ("username" is one word). Note that this won't apply to the github_other_user_name variables below, because that's actually built as github_<planid>_<fieldname>.

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"other_username"
```

reviewboard/hostingsvcs/github.py (Diff revision 2)

The issue has been resolved. Show all issues

"Desired" might be confusing to a lot of users, particularly non-English speakers.

"Other User's Repository" would be better.

reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"username" isn't right here. Let's use "owner".
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
These can be combined to one line, I believe.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's extend this to say:
" ... was not found, or is not publicly-accessible."
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
These are only relevant to organizations. You don't want them for this plan.
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Only one blank line here.
```
reviewboard/hostingsvcs/tests/test_github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you put each argument on its own line?
```

reviewboard/hostingsvcs/tests/test_github.py (Diff revision 2)

The issue has been resolved. Show all issues

Let's swap the order of these, so that it'll match the order in which they're presented in the form. This is just for readability purposes and consistency with the other tests.

Testing Done:

~		Ran unit tests with and without parameters, and had no errors.
	~	Ran unit tests with and without parameters, and had no errors.
-		It ran 2569 tests in 293.380 seconds.

		Manually tested user:chipx86 and repository name:baseconfigs.git,
		and it worked with no errors.

		When the plan is tested with random inputs for both username and
		repo name, we are given the correct error message.

Commit:

-	ae97f0702c9c41538ff1159f60772e617b699c1f
+	d1d7eb054a5e3c5aaedd2f4e6e8908be0e4d217a

Diff:

Revision 3 (+119 -24)

Show changes

	reviewboard/hostingsvcs/github.py
	reviewboard/hostingsvcs/tests/test_github.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Review Board 7.0 alpha 0 (dev)

Add a GitHub plan to use another user's repository.

Information

Reviewers

flake8

Testing Done:

Commit:

Diff:

Checks run (2 succeeded)

Testing Done:

Commit:

Diff:

Checks run (2 succeeded)

Status: Discarded