Add a GitHub plan to use another user's repository.
Review Request #9028 — Created June 20, 2017 and discarded
Previously, a user could only configure a repository within the user or an organization. With the addition of this plan, a user will be able to configure another user's repository by entering the user's name and desired repository. The error messages for all plans were also updated by using dictionaries and %s to get the user's name and repo's name, rather than outputting a static string.
Ran unit tests with and without parameters, and had no errors.
Manually tested user:chipx86 and repository name:baseconfigs.git,
and it worked with no errors.When the plan is tested with random inputs for both username and
repo name, we are given the correct error message.
| Description | From | Last Updated |
|---|---|---|
|
E501 line too long (84 > 79 characters) |
 reviewbot
|
|
|
E501 line too long (84 > 79 characters) |
reviewbot
|
|
|
E303 too many blank lines (2) |
reviewbot
|
|
|
Let's use "Owner's username" |
 chipx86
|
|
|
"org_name" should be "other_username" |
chipx86
|
|
|
Should use "other_username" ("username" is one word). Note that this won't apply to the github_other_user_name variables below, because that's actually … |
chipx86
|
|
|
"other_username" |
chipx86
|
|
|
"Desired" might be confusing to a lot of users, particularly non-English speakers. "Other User's Repository" would be better. |
chipx86
|
|
|
"username" isn't right here. Let's use "owner". |
chipx86
|
|
|
These can be combined to one line, I believe. |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
Let's extend this to say: " ... was not found, or is not publicly-accessible." |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
No blank line here. |
chipx86
|
|
|
These are only relevant to organizations. You don't want them for this plan. |
chipx86
|
|
|
Only one blank line here. |
chipx86
|
|
|
Can you put each argument on its own line? |
chipx86
|
|
|
Let's swap the order of these, so that it'll match the order in which they're presented in the form. This … |
chipx86
|
- Testing Done:
-
Ran unit tests with and without parameters, and had no errors.
~ It ran 2569 tests in 306.046 seconds. ~ It ran 2569 tests in 293.380 seconds. Manually tested user:chipx86 and repository name:baseconfigs.git,
and it worked with no errors. When the plan is tested with random inputs for both username and
repo name, we are given the correct error message. - Commit:
-
243c8b08ad064beab34a5dbf027b601e2276ca48ae97f0702c9c41538ff1159f60772e617b699c1f
Checks run (2 succeeded)
-
-
-
-
Should use "other_username" ("username" is one word). Note that this won't apply to the
github_other_user_namevariables below, because that's actually built asgithub_<planid>_<fieldname>. -
-
"Desired" might be confusing to a lot of users, particularly non-English speakers.
"Other User's Repository" would be better.
-
-
-
-
-
-
-
-
-
-
Let's swap the order of these, so that it'll match the order in which they're presented in the form. This is just for readability purposes and consistency with the other tests.
- Testing Done:
-
~ Ran unit tests with and without parameters, and had no errors.
~ Ran unit tests with and without parameters, and had no errors.
- It ran 2569 tests in 293.380 seconds. Manually tested user:chipx86 and repository name:baseconfigs.git,
and it worked with no errors. When the plan is tested with random inputs for both username and
repo name, we are given the correct error message. - Commit:
-
ae97f0702c9c41538ff1159f60772e617b699c1fd1d7eb054a5e3c5aaedd2f4e6e8908be0e4d217a
