Ticket-4551: add --no-renames option to 'rbt diff' for GIT repo

Review Request #9010 — Created June 12, 2017 and updated

totoroliu
RBTools
release-0.7.x
4551
8478c93...
rbtools
Ticket-4551: add --no-renames option to 'rbt diff' for GIT repo


Description From Last Updated

We need the summary, description, and testing done fields to be fleshed out and cleaned up. See https://www.notion.so/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for our ...

daviddavid

Should be "Git", not "GIT"

daviddavid

There's a typo in here (sgives), but the whole thing is not great language. How about "Force rename detection off, ...

daviddavid

Let's keep these (the SCM-specific things) in alphabetical order. That is, git before perforce.

daviddavid

Let's keep these (the SCM-specific things) in alphabetical order. That is, git before perforce.

daviddavid
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
TO
  1. Hi~
    Is there any update for this pull-request?
    What should I do next?

  2. 
      
KY
  1. Ship It!
  2. 
      
david
  1. I'm sorry for the delay on this.

  2. We need the summary, description, and testing done fields to be fleshed out and cleaned up. See https://www.notion.so/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for our guide on how to format these fields.

  3. rbtools/commands/__init__.py (Diff revision 1)
     
     

    Should be "Git", not "GIT"

  4. rbtools/commands/__init__.py (Diff revision 1)
     
     
     
     

    There's a typo in here (sgives), but the whole thing is not great language. How about "Force rename detection off, ignoring .gitconfig"?

  5. rbtools/commands/diff.py (Diff revision 1)
     
     
     
     
     

    Let's keep these (the SCM-specific things) in alphabetical order. That is, git before perforce.

  6. rbtools/commands/post.py (Diff revision 1)
     
     
     
     
     

    Let's keep these (the SCM-specific things) in alphabetical order. That is, git before perforce.

  7. 
      
Loading...