Summary

Update ReviewsDiffViewerView to use ReviewRequestViewMixin.

Review Request #9003 — Created June 6, 2017 and submitted July 5, 2017, 1:13 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

f498059...

Reviewers

Groups

reviewboard

People

Description

This standardizes parts of ReviewsDiffViewerView by using the new
ReviewRequestViewMixin. It centralizes the access checks and review
request fetching, along with improving the documentation, cleaning up
some styling, and adding defaults for member variables.

Testing Done

Tested that the diff viewer still works as expected.

flake8 passed.

JSHint passed.

Change Summary:

Cleaned up some more code in the class to reduce key lookups in dicts.

Commit:

a49051622ad6cf5b3ea596504627ce3171b4257d

3574205c8aae317790125cc72a615b00457fee92

Diff:

Revision 2 (+83 -45)

Show changes

reviewboard/reviews/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Switched to using self.get_diff instead of _query_for_diff.

Commit:

3574205c8aae317790125cc72a615b00457fee92

f4980599ac2182b2746a757e70c7124ce3e4f3b0

Diff:

Revision 3 (+85 -49)

Show changes

reviewboard/reviews/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (6ac674e)