• 
      

    Update from CodeMirror 5.8 to 5.26.

    Review Request #8990 — Created June 4, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    25ab068...

    Reviewers

    Modern versions of CodeMirror bring a lot of bug fixes, API
    improvements, compatibility fixes, and more. Along with upgrading, this
    build bundles new syntax highlighting modes for JSX and Swift, and
    includes a new plugin for optionally showing placeholder text for empty
    fields (which may prove useful for guidance later in new review requests
    or other fields).

    Tested all major editing and Markdown features in review request fields,
    comments, and replies.

    Description From Last Updated

    Col: 2236 This character may get silently deleted by one or more browsers.

    reviewbot reviewbot

    Col: 26 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 55 Expected '!==' and instead saw '!='.

    reviewbot reviewbot

    Col: 100 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 151 Expected an assignment or function call and instead saw an expression.

    reviewbot reviewbot

    Col: 152 Missing semicolon.

    reviewbot reviewbot

    Col: 243 Missing semicolon.

    reviewbot reviewbot

    Col: 296 Expected '{' and instead saw 'e'.

    reviewbot reviewbot

    Col: 332 Missing semicolon.

    reviewbot reviewbot

    Col: 375 Missing semicolon.

    reviewbot reviewbot

    Col: 483 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 492 Expected '{' and instead saw 'i'.

    reviewbot reviewbot

    Col: 544 Expected '{' and instead saw 'for'.

    reviewbot reviewbot

    Col: 571 Expected '{' and instead saw 'i'.

    reviewbot reviewbot

    Col: 599 Missing semicolon.

    reviewbot reviewbot

    Col: 683 Missing semicolon.

    reviewbot reviewbot

    Col: 706 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 746 Expected '{' and instead saw 'return'.

    reviewbot reviewbot

    Col: 770 Expected '{' and instead saw 'if'.

    reviewbot reviewbot

    Col: 777 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 803 Expected '===' and instead saw '=='.

    reviewbot reviewbot

    Col: 805 Expected '{' and instead saw 'return'.

    reviewbot reviewbot

    Col: 834 Expected a conditional expression and instead saw an assignment.

    reviewbot reviewbot

    Col: 835 Missing semicolon.

    reviewbot reviewbot

    Col: 883 Missing semicolon.

    reviewbot reviewbot

    Col: 914 Missing semicolon.

    reviewbot reviewbot

    Col: 965 Expected '{' and instead saw 'e'.

    reviewbot reviewbot

    Col: 1002 Missing semicolon.

    reviewbot reviewbot

    Col: 1077 Expected an assignment or function call and instead saw an expression.

    reviewbot reviewbot

    Col: 1078 Missing semicolon.

    reviewbot reviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 passed.
    JSHint failed.

    JSHint

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (7f7cf84)