Summary

Update from CodeMirror 5.8 to 5.26.

Review Request #8990 — Created June 4, 2017 and submitted June 5, 2017, 3:56 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

25ab068...

Reviewers

Groups

reviewboard

People

Description

Modern versions of CodeMirror bring a lot of bug fixes, API
improvements, compatibility fixes, and more. Along with upgrading, this
build bundles new syntax highlighting modes for JSX and Swift, and
includes a new plugin for optionally showing placeholder text for empty
fields (which may prove useful for guidance later in new review requests
or other fields).

Testing Done

Tested all major editing and Markdown features in review request fields,
comments, and replies.

Issues

Description	From	Last Updated
Col: 2236 This character may get silently deleted by one or more browsers.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 26 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 55 Expected '!==' and instead saw '!='.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 100 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 151 Expected an assignment or function call and instead saw an expression.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 152 Missing semicolon.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 243 Missing semicolon.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 296 Expected '{' and instead saw 'e'.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 332 Missing semicolon.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 375 Missing semicolon.	reviewbot	June 5, 2017, 3:29 p.m.
Col: 483 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 492 Expected '{' and instead saw 'i'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 544 Expected '{' and instead saw 'for'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 571 Expected '{' and instead saw 'i'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 599 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 683 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 706 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 746 Expected '{' and instead saw 'return'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 770 Expected '{' and instead saw 'if'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 777 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 803 Expected '===' and instead saw '=='.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 805 Expected '{' and instead saw 'return'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 834 Expected a conditional expression and instead saw an assignment.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 835 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 883 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 914 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 965 Expected '{' and instead saw 'e'.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 1002 Missing semicolon.	reviewbot	June 5, 2017, 3:30 p.m.
Col: 1077 Expected an assignment or function call and instead saw an expression.	reviewbot	June 5, 2017, 3:31 p.m.
Col: 1078 Missing semicolon.	reviewbot	June 5, 2017, 3:31 p.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 51 failures.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 2236
 This character may get silently deleted by one or more browsers.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 26
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 55
 Expected '!==' and instead saw '!='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 100
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 151
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 152
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 243
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 296
 Expected '{' and instead saw 'e'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 332
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 375
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 483
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 492
 Expected '{' and instead saw 'i'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 544
 Expected '{' and instead saw 'for'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 571
 Expected '{' and instead saw 'i'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 599
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 683
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 706
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 746
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 770
 Expected '{' and instead saw 'if'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 777
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 803
 Expected '===' and instead saw '=='.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 805
 Expected '{' and instead saw 'return'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 834
 Expected a conditional expression and instead saw an assignment.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 835
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 883
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 914
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 965
 Expected '{' and instead saw 'e'.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1002
 Missing semicolon.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1077
 Expected an assignment or function call and instead saw an expression.
```
reviewboard/static/lib/js/codemirror-5.26.min.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1078
 Missing semicolon.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7f7cf84)