Summary

Update the related user selector to use the new avatars API

Review Request #8985 — Created June 2, 2017 and submitted June 13, 2017, 3:24 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8984~~

Blocks

8986

Reviewers

Groups

reviewboard

People

Description

The related user selector was previously relying on the
integration_gravatars setting and the deprecated avatar_url field
from the UserResource. The selector now fetches avatar URLs from the
avatar services instead of always using Gravatars.

Testing Done

Tested the related user selector on the repository page with custom
avatars and gravatars. It worked as expected.

Issues

Description	From	Last Updated
Col: 11 Expected ')' and instead saw ';'.	reviewbot	June 2, 2017, 5:02 p.m.
Col: 9 Expected an identifier and instead saw ')'.	reviewbot	June 2, 2017, 5:02 p.m.
Col: 9 Unexpected ')'.	reviewbot	June 2, 2017, 5:02 p.m.
Col: 12 Missing semicolon.	reviewbot	June 2, 2017, 5:02 p.m.
Col: 11 Expected ')' and instead saw ';'.	reviewbot	June 2, 2017, 5:03 p.m.
Col: 12 Missing semicolon.	reviewbot	June 2, 2017, 5:03 p.m.
Col: 9 Expected an identifier and instead saw ')'.	reviewbot	June 2, 2017, 5:03 p.m.
Col: 9 Unexpected ')'.	reviewbot	June 2, 2017, 5:03 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 11
 Expected ')' and instead saw ';'.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected an identifier and instead saw ')'.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Unexpected ')'.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 12
 Missing semicolon.
```

Diff:

Revision 2 (+25 -31)

Show changes

	reviewboard/admin/form_widgets.py
	reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js
	reviewboard/templates/admin/related_user_widget.html

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 11
 Expected ')' and instead saw ';'.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 12
 Missing semicolon.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 Expected an identifier and instead saw ')'.
```
reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 Unexpected ')'.
```

Diff:

Revision 3 (+25 -31)

Show changes

	reviewboard/admin/form_widgets.py
	reviewboard/static/rb/js/admin/views/relatedUserSelectorView.es6.js
	reviewboard/templates/admin/related_user_widget.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (da80d3f)