Summary

Fix HTTP basic auth for hosting service clients

Review Request #8976 — Created May 26, 2017 and submitted May 26, 2017, 3:54 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

dcc700e...

Reviewers

Groups

reviewboard

People

Description

The patch /r/8911/ contained a regression that caused HTTP basic auth to
fail for hosting service clients. This patch fixes that regression and
adds unit tests for HTTP Basic Auth for the URLRequest and
HostingServiceClient classes.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
W293 blank line contains whitespace	reviewbot	May 26, 2017, 3:48 p.m.
W293 blank line contains whitespace	reviewbot	May 26, 2017, 3:48 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/hostingsvcs/tests/test_base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

flake8

Diff:

Revision 2 (+68 -1)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests/test_base.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:

-	Add unit tests for URLRequest and HostingServiceClient
+	Fix HTTP basic auth for hosting service clients

Description:

~		Add unit tests for HTTP Basic Auth for the URLRequest and
	~	The patch /r/8911/ contained a regression that caused HTTP basic auth to
	+	fail for hosting service clients. This patch fixes that regression and
	+	adds unit tests for HTTP Basic Auth for the URLRequest and
		HostingServiceClient classes.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (dad89de)