Added removable ship it labels such that a ship it label can be revoked only by the person who endorsed it in the first place.

Review Request #8946 - Created May 18, 2017 and discarded

Giorgio Busatto
Review Board
release-3.0.x
reviewboard

Added removable ship it labels such that a ship it label can be revoked only by the person who endorsed it in the first place.
To revoke a ship it, click on the X to the right of a ship it label.
Ship its can be revoked and the changes seen immediately.
Furthermore, the ship-it counter corresponding to the review request is duly updated (decremented) when a ship it is revoked.



Loading file attachments...

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Checks run (2 failed)
flake8 failed.
JSHint failed.

flake8

JSHint

Giorgio Busatto
  1. 
      
  2. This is a port of https://reviews.reviewboard.org/r/7170/ to branch release-3.0.x

  3. 
      
Giorgio Busatto
Review request changed
Giorgio Busatto
Barret Rennie
  1. 
      
  2. Can you add some screenshots of this new UI?

    1. I have added two screenshots. In the first you see a revoked and a new ship-it comment. In the new ship-it comment there is a button marked with X next to the text "Ship it!"
      After clicking on the button, the green frame and the "Ship it!" text are removed, as shown in the second screenshot.

      There is no further GUI change: in the dashboard the ship-it icon is displayed as before. This icon is shown or hidden according to the state of the review.

  3. 
      
Giorgio Busatto
Christian Hammond
  1. Thanks! I appreciate the porting work on this. There's some things I want to do to alter how this works just a bit. Aiming to get this in this week. Going to make some changes and re-post for review.

  2. 
      
Giorgio Busatto
  1. This change is now at https://reviews.reviewboard.org/r/8995/. Closing review.

  2. 
      
Giorgio Busatto
Review request changed

Status: Discarded

Loading...