Summary

Added removable ship it labels such that a ship it label can be revoked only by the person who endorsed it in the first place.

Review Request #8946 — Created May 18, 2017 and discarded June 13, 2017, 1:54 a.m.

Information

Owner

giorgiob

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added removable ship it labels such that a ship it label can be revoked only by the person who endorsed it in the first place.
To revoke a ship it, click on the X to the right of a ship it label.
Ship its can be revoked and the changes seen immediately.
Furthermore, the ship-it counter corresponding to the review request is duly updated (decremented) when a ship it is revoked.

Testing Done

Files

Issues

Description	From	Last Updated
Can you add some screenshots of this new UI?	brennie	May 29, 2017, 1:12 p.m.
Col: 21 'reviewRequest' is defined but never used.	reviewbot	May 18, 2017, 5:45 a.m.
E128 continuation line under-indented for visual indent	reviewbot	May 18, 2017, 5:46 a.m.
E501 line too long (95 > 79 characters)	reviewbot	May 18, 2017, 5:48 a.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/webapi/tests/test_review_request.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```

JSHint

reviewboard/static/rb/js/views/reviewBoxView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 'reviewRequest' is defined but never used.
```

This is a port of https://reviews.reviewboard.org/r/7170/ to branch release-3.0.x

Diff:

Revision 2 (+100 -6)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/reviewBoxView.es6.js
	reviewboard/templates/reviews/boxes/review.html
	reviewboard/webapi/resources/base_review.py
	reviewboard/webapi/tests/test_review.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_review_request.py (Diff revision 2)
The issue has been resolved. Show all issues
```
E501 line too long (95 > 79 characters)
```

Diff:

Revision 3 (+101 -6)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/reviewBoxView.es6.js
	reviewboard/templates/reviews/boxes/review.html
	reviewboard/webapi/resources/base_review.py
	reviewboard/webapi/tests/test_review.py
	reviewboard/webapi/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you add some screenshots of this new UI?

giorgiob May 29, 2017, 3:56 a.m.

I have added two screenshots. In the first you see a revoked and a new ship-it comment. In the new ship-it comment there is a button marked with X next to the text "Ship it!"
After clicking on the button, the green frame and the "Ship it!" text are removed, as shown in the second screenshot.

There is no further GUI change: in the dashboard the ship-it icon is displayed as before. This icon is shown or hidden according to the state of the review.

Added Files:

Thanks! I appreciate the porting work on this. There's some things I want to do to alter how this works just a bit. Aiming to get this in this week. Going to make some changes and re-post for review.

This change is now at https://reviews.reviewboard.org/r/8995/. Closing review.

Status:: Discarded