Fix a regression with the Quick Search functionality.

Review Request #8942 - Created May 16, 2017 and updated

Christian Hammond
Review Board
release-2.5.x
98c21f6...
reviewboard
Some work was done in a recent release to fix issues in Quick Search and
to document the parameters going to this API. The addition of the
documentation (using a decorator that specifies the available list of
parameters) was using strict validation, not allowing for unknown
parameters. This broke Quick Search, which passes in a timestamp
argument (not otherwise used by this API) in all requests.

We now ignore any arguments that aren't used by the API, fixing this
regression.

Unit tests pass.

Tested that Quick Search was working properly here. Sent the patch to
a customer and confirmed it fixed the problem for them.

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Trailing comma? David Trowbridge David Trowbridge
Checks run (2 succeeded)
JSHint passed.
flake8 passed.
David Trowbridge
  1. 
      
  2. reviewboard/webapi/resources/search.py (Diff revision 1)
     
     

    Trailing comma?

Loading...