• 
      

    Add support for touch events for comment creation in the diff viewer.

    Review Request #8930 — Created May 8, 2017 and submitted

    Information

    Review Board
    release-2.5.x
    7cb64a7...

    Reviewers

    This adds touchscreen support in the diff viewer for selecting rows and
    creating comments, and for opening existing comments. When using a
    device like an iPad, users can now tap-and-drag down line numbers to
    create a new comment, or tap a line with an existing comment to view it.
    This works just like using a mouse.

    The page will not scroll when creating a selection, helping to keep
    selections predictable. Dragging in any other column (such as the code
    columns) will continue to scroll the page.

    Selections can be cancelled by ending a drag outside of the line numbers
    column.

    Tested creating single-line comments on an iPad.

    Tested creating multi-line comments on an iPad.

    Tested dragging upwards and downwards, ensuring the selection is always
    correct.

    Tested ending a selection outside of the line numbers column to cancel
    the selection.

    Tested tapping a line with an existing comment to view that comment.

    Tested scrolling the page by dragging in other parts of the page.

    Tested that all mouse operations still worked correctly.

    Description From Last Updated

    Should be /**

    daviddavid

    Should be /**

    daviddavid

    Should be /**

    daviddavid

    Should be /**

    daviddavid
    david
    1. 
        
    2. Show all issues

      Should be /**

    3. Show all issues

      Should be /**

    4. Show all issues

      Should be /**

    5. Show all issues

      Should be /**

    6. 
        
    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (cbe9524)