Add error handling for test e-mail.

Review Request #8924 - Created May 7, 2017 and updated

Ezra Buehler
Review Board
release-2.5.x
20e7b81...
reviewboard

When updating e-mail server settings having "Send a test e-mail after
saving" selected it is helpful to get some feedback when the e-mail
could not be sent. With this change an error message is displayed and
the exception logged.

Configured e-mail server (smtp.gmail.com) with wrong username, wrong
password, no TLS, misspelled server and observed error message and
exception in log for every case. Using an invalid port resulted in a
timeout.

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Ezra Buehler
Barret Rennie
Ezra Buehler
Review request changed

Testing Done:

  +

Configured e-mail server (smtp.gmail.com) with wrong username, wrong

  + password, no TLS, misspelled server and observed error message and
  + exception in log for every case. Using an invalid port resulted in a
  + timeout.

Branch:

-master
+release-2.5.x

Commit:

-7c5703ad39e02b2230b801b87e73b492dc703631
+20e7b819896f1890ce9a861972d55e294a5ff39f

Diff:

Revision 2 (+13 -7)

Show changes

Checks run (2 succeeded)

JSHint passed.
flake8 passed.
Barret Rennie
  1. Ship It!
Loading...