JSHint
passed.
PEP8 Style Checker
passed.
Pyflakes
passed.
Add error handling for test e-mail.
Review Request #8924 — Created May 7, 2017 and submitted
When updating e-mail server settings having "Send a test e-mail after
saving" selected it is helpful to get some feedback when the e-mail
could not be sent. With this change an error message is displayed and
the exception logged.
Configured e-mail server (smtp.gmail.com) with wrong username, wrong
password, no TLS, misspelled server and observed error message and
exception in log for every case. Using an invalid port resulted in a
timeout.
| Description | From | Last Updated |
|---|---|---|
|
Can you move this over to the release-2.5.x branch and verify it works there? This would be great to have … |
 brennie
|
|
|
Can you add some information to the testing done? |
brennie
|
|
|
Instead of using logging.error(msg, exc_info=True), you can just do logging.exception(msg). |
brennie
|
Description: |
|
|---|
-
-
Can you move this over to the
release-2.5.xbranch and verify it works there? This would be great to have on all supported releases! -
-
reviewboard/admin/forms.py (Diff revision 1) Instead of using
logging.error(msg, exc_info=True), you can just dologging.exception(msg).
Testing Done: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Branch: |
|
||||||||||||
Commit: |
|
||||||||||||
Diff: |
Revision 2 (+13 -7) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
