Add error handling for test e-mail.

Review Request #8924 - Created May 7, 2017 and submitted

Ezra Buehler
Review Board
release-2.5.x
20e7b81...
reviewboard

When updating e-mail server settings having "Send a test e-mail after
saving" selected it is helpful to get some feedback when the e-mail
could not be sent. With this change an error message is displayed and
the exception logged.

Configured e-mail server (smtp.gmail.com) with wrong username, wrong
password, no TLS, misspelled server and observed error message and
exception in log for every case. Using an invalid port resulted in a
timeout.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Ezra Buehler
Barret Rennie
  1. Thanks for the contribution! I have a few minor quibbles:

  2. Can you add some information to the testing done?

  3. Can you move this over to the release-2.5.x branch and verify it works there? This would be great to have on all supported releases!

  4. reviewboard/admin/forms.py (Diff revision 1)
     
     

    Instead of using logging.error(msg, exc_info=True), you can just do logging.exception(msg).

  5. 
      
Ezra Buehler
Barret Rennie
  1. Ship It!
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Ezra Buehler
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (0d8c495)
Loading...