Summary:

Add error handling for test e-mail.

Review Request #8924 — Created May 7, 2017 and submitted July 3, 2017, 1:16 p.m.

Information
Owner:	easyb
Repository:	Review Board
Branch:	release-2.5.x
Bugs:
Depends On:
Commit:	20e7b81...
Reviewers
Groups:	reviewboard
People:

Description

When updating e-mail server settings having "Send a test e-mail after
saving" selected it is helpful to get some feedback when the e-mail
could not be sent. With this change an error message is displayed and
the exception logged.

Testing Done

Configured e-mail server (smtp.gmail.com) with wrong username, wrong
password, no TLS, misspelled server and observed error message and
exception in log for every case. Using an invalid port resulted in a
timeout.

Issues

Description	From	Last Updated
Can you move this over to the release-2.5.x branch and verify it works there? This would be great to have …	brennie	May 9, 2017, 12:46 p.m.
Can you add some information to the testing done?	brennie	May 9, 2017, 12:46 p.m.
Instead of using logging.error(msg, exc_info=True), you can just do logging.exception(msg).	brennie	May 9, 2017, 12:45 p.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Description:

~		When updating e-mail settings having "Send a test e-mail after saving"
~		selected it is helpful to get some feedback when the e-mail could not
~		be sent. With this change an error message is displayed and the
~		exception logged.
	~	When updating e-mail server settings having "Send a test e-mail after
	~	saving" selected it is helpful to get some feedback when the e-mail
	~	could not be sent. With this change an error message is displayed and
	~	the exception logged.

Thanks for the contribution! I have a few minor quibbles:

Show all issues

Can you move this over to the release-2.5.x branch and verify it works there? This would be great to have on all supported releases!

Show all issues

Can you add some information to the testing done?

reviewboard/admin/forms.py (Diff revision 1)

Show all issues

Instead of using logging.error(msg, exc_info=True), you can just do logging.exception(msg).

Testing Done:

	+	Configured e-mail server (smtp.gmail.com) with wrong username, wrong
	+	password, no TLS, misspelled server and observed error message and
	+	exception in log for every case. Using an invalid port resulted in a
	+	timeout.