Move HTTP basic auth into URLRequest

 






 

 


  Review Request #8911
  —
  Created April 21, 2017 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  Review Board
 









 
 

  release-2.5.x
 









 
 

  
 









 
 

  8910
 









 
 

  8912
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The logic for adding HTTP basic auth headers to a request has been moved

into the URLRequest class since it is generally useful. In addition,

the HostingServiceClient._build_request method has been removed since

it was used in one place; its definition has been moved inline.

 








  


 
 

  
Ran unit tests.