Move HTTP basic auth into URLRequest

Review Request #8911 — Created April 21, 2017 and submitted

brennie
Review Board
release-2.5.x
8910
8912
reviewboard

The logic for adding HTTP basic auth headers to a request has been moved
into the URLRequest class since it is generally useful. In addition,
the HostingServiceClient._build_request method has been removed since
it was used in one place; its definition has been moved inline.

Ran unit tests.

Description From Last Updated

undefined name 'password'

reviewbotreviewbot

undefined name 'username'

reviewbotreviewbot

undefined name 'username'

reviewbotreviewbot

undefined name 'password'

reviewbotreviewbot

Should be only one blank line after this.

chipx86chipx86
Checks run (1 failed, 1 succeeded, 1 failed with error)
JSHint passed.
PEP8 Style Checker internal error.
Pyflakes failed.

Pyflakes

brennie
chipx86
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 2)
     
     
     

    Should be only one blank line after this.

  3. 
      
brennie
brennie
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (19ddbe6)
Loading...