Summary

Move HTTP basic auth into URLRequest

Review Request #8911 — Created April 21, 2017 and submitted May 22, 2017, 10:54 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

~~8910~~

Blocks

8912

Reviewers

Groups

reviewboard

People

Description

The logic for adding HTTP basic auth headers to a request has been moved

into the URLRequest class since it is generally useful. In addition,

the HostingServiceClient._build_request method has been removed since

it was used in one place; its definition has been moved inline.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
undefined name 'password'	reviewbot	April 21, 2017, 8:34 p.m.
undefined name 'username'	reviewbot	April 21, 2017, 8:34 p.m.
undefined name 'username'	reviewbot	April 21, 2017, 8:34 p.m.
undefined name 'password'	reviewbot	April 21, 2017, 8:34 p.m.
Should be only one blank line after this.	chipx86	April 24, 2017, 7:46 p.m.

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes failed.

Pyflakes

reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'password'
```
reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'username'
```
reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'username'
```
reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'password'
```