Modernize hostingsvcs.service.URLRequest

Review Request #8909 - Created April 22, 2017 and submitted

Barret Rennie
Review Board
release-2.5.x
8910
reviewboard

The URLRequest initializer was using a mutable object ({}) for its
default value of its headers parameter, which would persist to other
requests if it was modified. We now use a default value of None and
change it to an empty dict in the method call.

Documentation has been added for the class and its methods.

Built the docs and read through them.
Ran unit tests.

  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Christian Hammond
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     

    I don't think we need to use literals for HTTP GET/POST.

  3. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     
  4. reviewboard/hostingsvcs/service.py (Diff revision 1)
     
     
     
     
     

    Can simplify with:

    super(...).__init__(..., headers or {})
    
  5. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
David Trowbridge
  1. 
      
  2. reviewboard/hostingsvcs/service.py (Diff revision 2)
     
     

    Actually, hold on. Request is an old-style class that can't be used with super.

  3. 
      
Barret Rennie
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (0723f45)
Loading...