Summary

Modernize hostingsvcs.service.URLRequest

Review Request #8909 — Created April 21, 2017 and submitted May 22, 2017, 10:54 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Blocks

8910

Reviewers

Groups

reviewboard

People

Description

The URLRequest initializer was using a mutable object ({}) for its

default value of its headers parameter, which would persist to other

requests if it was modified. We now use a default value of None and

change it to an empty dict in the method call.
Documentation has been added for the class and its methods.

Testing Done

Built the docs and read through them.
Ran unit tests.

Issues

Description	From	Last Updated
I don't think we need to use literals for HTTP GET/POST.	chipx86	April 24, 2017, 7:42 p.m.
"URL"	chipx86	April 24, 2017, 7:42 p.m.
Can simplify with: super(...).__init__(..., headers or {})	chipx86	April 24, 2017, 7:42 p.m.
Actually, hold on. Request is an old-style class that can't be used with super.	david	May 1, 2017, 5:36 p.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I don't think we need to use literals for HTTP GET/POST.
```
reviewboard/hostingsvcs/service.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"URL"
```

reviewboard/hostingsvcs/service.py (Diff revision 1)

The issue has been resolved. Show all issues

Can simplify with:

super(...).__init__(..., headers or {})

Change Summary:

Addressed Christian's issues

Diff:

Revision 2 (+31 -2)

Show changes

reviewboard/hostingsvcs/service.py

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Ship it!

```
Ship It!
```

reviewboard/hostingsvcs/service.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Actually, hold on. Request is an old-style class that can't be used with super.
```

Change Summary:

Undo super()

Diff:

Revision 3 (+32 -2)

Show changes

reviewboard/hostingsvcs/service.py

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Description:: The URLRequest initializer was using a mutable object ({}) for its
default value of its headers parameter, which would persist to other
requests if it was modified. We now use a default value of None and
change it to an empty dict in the method call.

-
Additionally, it was invoking the base class __init__ method instead
- of using super(). This, too, has been corrected.
-

Documentation has been added for the class and its methods.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (0723f45)

		The `URLRequest` initializer was using a mutable object (`{}`) for its
		default value of its headers parameter, which would persist to other
		requests if it was modified. We now use a default value of `None` and
		change it to an empty dict in the method call.

-		Additionally, it was invoking the base class `__init__` method instead
-		of using `super()`. This, too, has been corrected.
-
		Documentation has been added for the class and its methods.