Fix the display of bug links in the dashboard when there's no repository.

Review Request #8904 - Created April 17, 2017 and submitted

Christian Hammond
Review Board
release-2.5.x
0d32248...
reviewboard
When a repository is not configured with a bug tracker, or a review
request is not associated with a repository, the bug links shown in the
dashboard still appear as clickable links. When there's multiple bugs,
they appear as one big link. This is because the row is set to be
clickable, and the column wasn't specifying it wanted to link to
something itself.

Now the column turns linking on but doesn't return any global links,
ensuring only the specific bug links within the cell are clickable.
There's also some styling fixes to make sure the links look correct and
that bugs don't prematurely wrap when there's no link to the bug.

Tested links and cursor for the bugs cells for review requests without
a repository, review requests with a repository and no bug tracker, and
review requests with a repository and bug tracker.

  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
David Trowbridge
  1. Ship It!
  2. 
      
Barret Rennie
  1. 
      
  2. reviewboard/datagrids/columns.py (Diff revision 1)
     
     

    We don't have a span.bug style. Semantically, shouldn't this be .bugs (since it will contain one or more a.bug ?

    1. It's defined in the stylesheet. .bug turns off word-wrapping, a.bug does linking. This is the per-item format string.

  3. 
      
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (e9004a8)
Loading...