Prevent links to bugs in e-mails for review requests without a repository.

Review Request #8901 — Created April 17, 2017 and submitted

Christian Hammond
Review Board
The e-mail templates for review request e-mails made a bad assumption
that the review request in question had a repository. This is from the
time when all review requests required a repository. The assumption
caused a check for bug link building to go down the wrong code path,
resulting in every bug having a link to "None" (or, in the case of text
e-mails, having a "None" simply appear below the bug number).

The templates now check for the existence of the repository first,
solving this. The template tag usage has also been modernized in these

Tested HTML and plain-text e-mails for review requests without a
repository, with a repository but no bug tracker, and with a repository with
a bug tracker.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Trowbridge
  2. Can we switch this so we have if review_request.repository and review_request.repository.bug_tracker first?

Christian Hammond
David Trowbridge
  1. Ship It!
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (6ba90e6)