Get rid of die().
Review Request #8899 — Created April 14, 2017 and submitted
The
die()
method is one of the most ancient parts of RBTools, and it's long
outlived its usefulness, especially now that more and more people are using
RBTools as an API and not just a command.This change gets rid of it in favor of using exceptions, which are already all
handled correctly.
- Smoke tested rbt commands.
- Ran unit tests.
-
-
rbtools/clients/perforce.py (Diff revision 1) If we don't catch this, wont it be printed as:
ERRROR: ERROR, no valid diffs: ...
bceause of logging? Either way, I don't think we need theERROR,
at the beginning -
-
rbtools/utils/process.py (Diff revision 1) Would it be appropriate to use
subprocess.CalledProcessError
here?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+72 -85) |
Checks run (2 succeeded, 1 failed with error)
JSHint
passed.
PEP8 Style Checker
internal error.
Pyflakes
passed.